You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Integrated the Unity-Neurosity sdk into our repo
Added a script for blink detection in the Blink detection folder in scripts
Modified that RawBrainwaves Handler to call our blink detection and print BLINK DETECTED when the conditions are met
Steps to test
Make sure you have git LFS set up
Install the dependencies needed in the README
Open the game and make sure there are no errors in the console that prevent you from running
What should reviewers focus on?
Will make a new ticket to integrate in the actual game once an integration scene is created
Checklist
My PR name is descriptive
My commit messages are descriptive. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
I have run the appropriate linter(s)
I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR
My code is organized, and commented and documented so that another dev can understand what I did
I'm assuming the dependencies needed downloading are in this readme?
Which ones are needed? The readme isn't too clear on which ones we need 😅 (also not too sure why I'm getting an error saying I need the iOS packages if we aren't using iOS specifically? idk)
Also wondering, can they not be added to our package manifest?
I'm assuming the dependencies needed downloading are in this readme?
Which ones are needed? The readme isn't too clear on which ones we need 😅 (also not too sure why I'm getting an error saying I need the iOS packages if we aren't using iOS specifically? idk)
Also wondering, can they not be added to our package manifest?
Good point. I added them to the manifest and updated the pr. Im pretty sure the ios thing is just a warning error but lmk if you still see it now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BCI-integration
[Integrate Neurosity and Blink detection]
Implementation description
Integrated the Unity-Neurosity sdk into our repo
Added a script for blink detection in the Blink detection folder in scripts
Modified that RawBrainwaves Handler to call our blink detection and print BLINK DETECTED when the conditions are met
Steps to test
What should reviewers focus on?
Will make a new ticket to integrate in the actual game once an integration scene is created
Checklist