Skip to content

Alexis neurosity#45

Open
alexisbader wants to merge 13 commits intomainfrom
alexis-neurosity
Open

Alexis neurosity#45
alexisbader wants to merge 13 commits intomainfrom
alexis-neurosity

Conversation

@alexisbader
Copy link
Collaborator

BCI-integration

[Integrate Neurosity and Blink detection]

Implementation description

Integrated the Unity-Neurosity sdk into our repo
Added a script for blink detection in the Blink detection folder in scripts
Modified that RawBrainwaves Handler to call our blink detection and print BLINK DETECTED when the conditions are met

Steps to test

  1. Make sure you have git LFS set up
  2. Install the dependencies needed in the README
  3. Open the game and make sure there are no errors in the console that prevent you from running

What should reviewers focus on?

Will make a new ticket to integrate in the actual game once an integration scene is created

Checklist

  • My PR name is descriptive
  • My commit messages are descriptive. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR
  • My code is organized, and commented and documented so that another dev can understand what I did

@kimchiloof
Copy link
Contributor

I'm assuming the dependencies needed downloading are in this readme?

Which ones are needed? The readme isn't too clear on which ones we need 😅 (also not too sure why I'm getting an error saying I need the iOS packages if we aren't using iOS specifically? idk)

Also wondering, can they not be added to our package manifest?

@alexisbader
Copy link
Collaborator Author

I'm assuming the dependencies needed downloading are in this readme?

Which ones are needed? The readme isn't too clear on which ones we need 😅 (also not too sure why I'm getting an error saying I need the iOS packages if we aren't using iOS specifically? idk)

Also wondering, can they not be added to our package manifest?

Good point. I added them to the manifest and updated the pr. Im pretty sure the ios thing is just a warning error but lmk if you still see it now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants