Skip to content

Commit

Permalink
Finalized Repository
Browse files Browse the repository at this point in the history
  • Loading branch information
WHAHA-HA committed Feb 2, 2021
1 parent 55c6566 commit c6f319d
Show file tree
Hide file tree
Showing 6 changed files with 15 additions and 17 deletions.
1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
# Byte-compiled / optimized / DLL files
Solutions/DataStructures/__pycache__
__pycache__/*
*.py[cod]
*.pyo
Expand Down
17 changes: 8 additions & 9 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,32 +14,31 @@ contributors, you agree and confirm that:

- Your work will be distributed under [MIT License](LICENSE.md) once your pull
request is merged.
- You submitted work fulfils the styles and standards of this repository.
- You submitted work fulfills the styles and standards of this repository.

### Contribution

Any contribution, from fixing a grammatical mistake in a comment to improvising current
Any contribution, from fixing a grammatical errors in a comment to improvising current
solutions is appriciated.

**New implementation** is welcome as long as the solution improvises the
`Time Complexity` and/or `Space Complexity` without deteriorating the either of them
compared to the current solution! But **identical implementation** of an existing
solution is not allowed.
compared to the current solution. But **identical implementation** of an existing
solution will not be accepted.

**Improving comments** are also highly welcome. But **fake pull requests**, like
_unnecessarily changing the wording or adding 'a' or 'the', are highly discouraged_.
_unnecessarily changing the wording, adding 'a' or 'the', etc_ are highly discouraged.
Such pull requests will be closed immediately and labeled as `invalid`.

### Other Requirements for Submissions

- Use [black](https://pypi.org/project/black/) to format you code.
- Strictly use **PascalCase** for class names and**snake_case** in your variable and
- Strictly use **PascalCase** for class names and **snake_case** in your variable and
function names.
- If you have modified/added code work, make sure the code compiles before
submitting.
- If you have modified/added documentation work, ensure your language is concise and
contains no grammatical errors.
- Do not update the README.md file.
- If you have modified/added code work, make sure the code compiles before
submitting.
- Make sure to add
[**Python type hints**](https://docs.python.org/3/library/typing.html) to all
functions and methods.
Expand Down
2 changes: 1 addition & 1 deletion LICENSE
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
MIT License

Copyright (c) 2019 Tapajyoti Bose
Copyright (c) 2021 Tapajyoti Bose

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
Expand Down
8 changes: 4 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,17 +2,17 @@

This repository contains the **[Daily Coding Problem](https://www.dailycodingproblem.com)** solutions in python.

## Contribution Guidelines

Read our [Contribution Guidelines](CONTRIBUTING.md) before you contribute.

## Setup

Install the 3rd party packages, perform the following steps:

1. `cd Daily-Coding-Challenge-Solutions`
2. Run `pip install -r requirements.txt`

## Contribution Guidelines

Please go through [Contribution Guidelines](CONTRIBUTING.md) before you contribute.

## Note:

1. Modules `numpy` and `matplotlib` are used for presentation purpose only and hence are optional.
Expand Down
4 changes: 2 additions & 2 deletions Solutions/364.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@ def get_longest_increasing_subsequence(arr: List[int]) -> int:
tail_table[result_length] = arr[i]
result_length += 1
else:
# current element is the last candidate of an existing subsequence.
# it will replace ceil value in tail_table
# current element is the last candidate of an existing subsequence and will
# replace ceil value in tail_table
tail_table[get_ceil_index(tail_table, -1, result_length - 1, arr[i])] = arr[
i
]
Expand Down
Binary file modified requirements.txt
Binary file not shown.

0 comments on commit c6f319d

Please sign in to comment.