Skip to content

Update nested-explainer.md #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update nested-explainer.md #247

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 18 additions & 17 deletions nested-explainer.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ Instead of a flat tree, the author can nest `::view-transition-group` pseudo-ele
This is done with a new property, `view-transition-group`, which when applied on an element with a `view-transition-name`, defines whether the generated `::view-transition-group` gets nested in one of its containers,
or it would nest its own participating descendants.

The generated pseudo-element tree would now be nested.
The generated pseudo-element tree would now be nested, with nested `::view-transition-group` pseudo-elements grouped into a new `::view-transition-group-children` pseudo.
Example:

HTML:
Expand All @@ -48,14 +48,14 @@ Result:
```
// container does not clip icon
::view-transition
::view-transition-group(container)
::view-transition-image-pair(container)
::view-transition-old(container)
::view-transition-new(container)
::view-transition-group(icon)
::view-transition-image-pair(icon)
::view-transition-old(icon)
::view-transition-new(icon)
├─ ::view-transition-group(container)
| ├─ ::view-transition-image-pair(container)
| | ├─ ::view-transition-old(container)
| | └─ ::view-transition-new(container)
└─ ::view-transition-group(icon)
└─ ::view-transition-image-pair(icon)
├─ ::view-transition-old(icon)
└─ ::view-transition-new(icon)
```

With `view-transition-group`:
Expand All @@ -73,14 +73,15 @@ Result:
```
// container clips icon
::view-transition
::view-transition-group(container)
::view-transition-image-pair(container)
::view-transition-old(container)
::view-transition-new(container)
::view-transition-group(icon)
::view-transition-image-pair(icon)
::view-transition-old(icon)
::view-transition-new(icon)
└─ ::view-transition-group(container)
├─ ::view-transition-image-pair(container)
| ├─ ::view-transition-old(container)
| └─ ::view-transition-new(container)
└─ ::view-transition-group-children(container)
└─ ::view-transition-group(icon)
└─ ::view-transition-image-pair(icon)
├─ ::view-transition-old(icon)
└─ ::view-transition-new(icon)
```

Note that for the pseudo-element to clip its children, we still need to explicitly copy the `clip-path` property in this case.
Expand Down