feat: Export everything under a single module name#176
Merged
Conversation
|
🚀 Preview deployment ready! (2 deployments) 📍 Preview URL: https://preview-176.svelte-router.pages.dev This preview updates automatically when you push new commits to this PR. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR consolidates all exports from the @svelte-router/core/kernel sub-module into the main @svelte-router/core module to simplify library consumption in micro-frontend scenarios where the entire library needs to be externalized. The sub-module is deprecated as of v1.0.4 and will be removed in v2.0.
Key changes:
- Re-exported all kernel module functions and classes through the main module index
- Updated all documentation and code examples to import from
@svelte-router/coreinstead of@svelte-router/core/kernel - Added deprecation warnings in API documentation about the kernel sub-module
Reviewed changes
Copilot reviewed 13 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/lib/index.ts | Added exports for 11 items previously only available from kernel sub-module |
| src/lib/index.test.ts | Updated test to verify all newly exported items are accessible from main module |
| playground/src/App.svelte | Consolidated imports from both modules into single import from main module |
| src/routes/docs/routing-with-javascript/+page.md | Updated import examples to use main module instead of kernel sub-module |
| src/routes/docs/routing-with-components/+page.md | Consolidated imports in component examples |
| src/routes/docs/redirecting/+page.md | Updated imports for calculateHref and calculateMultiHashFragment |
| src/routes/docs/reactive-data/+page.md | Combined type import with component imports |
| src/routes/docs/navigating-with-javascript/+page.md | Reformatted imports as multi-line single import statement |
| src/routes/docs/library-modes/+page.md | Updated isConformantState import source |
| src/routes/api/kit/functions/+page.md | Removed redundant import source annotations |
| src/routes/api/core/objects-and-classes/+page.md | Added deprecation warning and removed kernel sub-module references |
| src/routes/api/core/functions/+page.md | Added deprecation warning and removed import annotations |
| src/routes/docs/loc/+page.md | Added version history entries for 1.0.2, 1.0.3, and 1.0.4 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR repeats all exports from the
@svelte-router/core/kernelsub-module in the main module,@svelte-router/core. This is to allow externalizing the entire library in one go when doing micro-frontends.From now on, don't consume the submodule
@svelte-router/core/kernel.