fix(InterceptedHistoryApi): Only override pushState and replaceState#178
Merged
fix(InterceptedHistoryApi): Only override pushState and replaceState#178
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR modifies the InterceptedHistoryApi to selectively override only the pushState and replaceState methods of the browser's window.history object, rather than replacing the entire history object. This is a more surgical approach that reduces potential side effects and maintains better compatibility with other code that might interact with the history API.
Key changes:
- Store and override only
pushStateandreplaceStatemethods instead of replacing the entirehistoryobject - Update disposal logic to restore only the overridden methods
- Update tests to verify method-level overrides rather than object replacement
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/lib/kernel/InterceptedHistoryApi.svelte.ts | Changed from storing/replacing entire history object to storing/overriding only pushState and replaceState methods |
| src/lib/kernel/InterceptedHistoryApi.svelte.test.ts | Updated tests to verify method-level interception and restoration instead of object replacement |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #174.