Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes issue #182 by correcting the regex pattern for rest parameters to properly handle empty matches. The updated pattern changes from (?<rest>\/.*) to (?<rest>(?:\/.*|$)), allowing rest parameters to match either a path segment or an empty string at the end of the pattern.
Key Changes:
- Updated the rest parameter regex pattern to support empty matches using alternation with
$anchor - Added comprehensive test cases to verify the fix handles edge cases, including empty rest parameters and paths with similar text
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/lib/kernel/RouteHelper.svelte.ts | Updated rest parameter regex to allow empty matches by adding ` |
| src/lib/kernel/RouteHelper.svelte.test.ts | Updated expected regex patterns and added new test cases for empty rest parameters and similar path text scenarios |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #182.