Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix boot in RAM fastboot procedures #2

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix boot in RAM fastboot procedures #2

wants to merge 2 commits into from

Conversation

NetuserPRO
Copy link

No description provided.

@gus33000
Copy link
Member

This PR breaks more than it fixes. Please review your changes again. Should be quite obvious.

@gus33000 gus33000 added enhancement New feature or request invalid This doesn't seem right labels Aug 16, 2024
gus33000
gus33000 requested changes Aug 16, 2024
View reviewed changes
Copy link
Member

@gus33000 gus33000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks existing functionality in a very bad way. You should be changing the code instead to assign a new value to the storage file variable and not delete belows if block and Var assignment. This ain't the right fix for this problem.

@NetuserPRO NetuserPRO requested a review from gus33000 August 16, 2024 19:55
@gus33000
Copy link
Member

gus33000 commented Oct 7, 2024

I still have a problem with the check verifying the file exists being removed

gus33000
gus33000 requested changes Oct 7, 2024
View reviewed changes
Copy link
Member

@gus33000 gus33000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gus33000 gus33000 gus33000 requested changes

Assignees
No one assigned
Labels
enhancement New feature or request invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NetuserPRO @gus33000