ci: detect untracked files in verify-build drift check - #12
Merged
Conversation
git diff only compares tracked files, so a new file added under skills/ after a build was invisible to the check and CI passed green even when the contributor forgot to commit it. Switch to git status --porcelain which surfaces untracked, modified, and deleted entries. Closes #2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
git diff --quiet -- skills/only inspects tracked files, so a newly created file underskills/after a build was invisible to the check and CI would pass even though the contributor forgot to commit it.git status --porcelain -- skills/, which surfaces untracked, modified, and deleted entries, and print the offending paths in the error output.Closes #2
Test plan
src/skills/.../foo.md, runbash scripts/build.sh, commit onlysrc/, push: CI should now fail and list the untrackedskills/.../foo.md.