Conversation
The repository's default branch is develop, but the workflow only ran on pushes to main. Direct commits to develop now also trigger verification. Closes #1
…evelop ci: run verify-build on pushes to develop
git diff only compares tracked files, so a new file added under skills/ after a build was invisible to the check and CI passed green even when the contributor forgot to commit it. Switch to git status --porcelain which surfaces untracked, modified, and deleted entries. Closes #2
…acked-files ci: detect untracked files in verify-build drift check
Step 6 treated any non-empty .code as terminal and broke out of the poll, but the /processes status enum includes "pending" — a queued process surfaces a non-empty but non-terminal code, so the loop would declare success while the update was still running. Replace the truthy check with an explicit case match against the three terminal codes (success, failed, finished) and default missing .code to "pending" so the still-running signal is unambiguous. Also document the canonical terminal codes in SKILL.md section 6 so future workflow authors do not re-introduce the same bug. Closes #4
…e-poll-terminal-codes fix: match terminal codes explicitly in safe-plugin-update poll
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Patch release. Closes the three remaining v0.1.0 read-through findings.
verify-buildCI now also runs on pushes todevelop(the default branch), not justmain.verify-builddrift check usesgit status --porcelain, so newly added (untracked) files underskills/no longer slip past CI.safe-plugin-updateStep 6 polling now matches terminalcodevalues explicitly (success/failed/finished) viacase, instead of treating any non-empty.codeas terminal —pendingno longer falsely declares the update finished. Canonical terminal codes documented inSKILL.md§6.0.1.4in.claude-plugin/plugin.json.Test plan
verify-buildCI green on this PR.v0.1.4onmainand publish the GitHub release.