fix: anchor allowlist host pattern and surface caveman stderr (#3, #5) - #8
Merged
Conversation
Closes #3, closes #5. #3 — `*public-api.wp-umbrella.com*` matched lookalike hosts (`public-api.wp-umbrella.com.attacker.tld`, `attackerpublic-api.wp-umbrella.com`, or any URL with the hostname in the query string), so a prompt-injected URL could exfiltrate the bearer token without a confirmation prompt. Anchored to `https://public-api.wp-umbrella.com/*` in both `.claude/settings.json` and `src/skills/umbrella/references/permissions.md`. Users who copy-pasted the loose pattern into `~/.claude/settings.json` should update it. #5 — `compress_file` redirected `>/dev/null 2>&1`, but the comment only mentioned silencing stdout. When caveman failed, the underlying error was hidden and the build only printed the generic wrapper message. Dropped `2>&1` so stderr flows through to the build log on failure. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two small, independent security/DX fixes from the v0.1.0 read-through.
.claude/settings.json,src/skills/umbrella/references/permissions.mdscripts/build.sh#3 — Allowlist host pattern
*public-api.wp-umbrella.com*matched lookalike hosts wherepublic-api.wp-umbrella.comappears anywhere in the URL string:https://public-api.wp-umbrella.com.attacker.tld/...(suffix attack)https://attackerpublic-api.wp-umbrella.com/...(prefix attack)https://example.com/?leak=public-api.wp-umbrella.com(hostname in query string)A prompt-injected response that nudged the agent toward one of those URLs would auto-approve and leak the bearer token. Anchored to
https://public-api.wp-umbrella.com/*in both the project allowlist and the user-facing copy inpermissions.md.Heads-up for existing installs: users who copy-pasted the loose pattern into
~/.claude/settings.jsonshould update theirs to the new form. Worth a one-liner in the next release notes.#5 — Caveman stderr
compress_filedid>/dev/null 2>&1, hiding the underlying caveman error on every failure — only the genericERROR: caveman compression failed for $fileline surfaced. The comment above the redirect only ever mentioned silencing stdout, so the2>&1was unintentional. Dropped it. Stdout still goes to/dev/null(matches original intent), stderr now passes through.Build verification
UMBRELLA_SKIP_COMPRESS=1 bash scripts/build.sh→✓ Build complete — 8 markdown file(s) copieddiff -r src/skills skills→ empty (v0 parity preserved).claude/settings.json,scripts/build.sh,src/skills/umbrella/references/permissions.md,skills/umbrella/references/permissions.mdTest plan
https://public-api.wp-umbrella.com/projectswith a Bearer tokenhttps://public-api.wp-umbrella.com.example.com/claudenot on PATH won't trigger this since the script short-circuits — easiest is to temporarily makeclaude -pexit 1) and confirm the underlying message reaches the build logCloses #3, closes #5.