fix: align safe-plugin-update Step 6 poll with project-scoped endpoint (#6) - #9
Merged
Merged
Conversation
Closes #6. Step 6 polled the global `/processes?per_page=20` while Step 7 read from `/projects/<ID>/processes?per_page=20`. The mismatch was internally inconsistent and, more importantly, unreliable for users with many concurrent processes: the freshly-created processId could drop off page 1 of the global feed within seconds, causing the poll to never find a match and the loop to silently time out as "still queued" even when the update had finished. Switch Step 6 to the same project-scoped endpoint as Step 7. The polling logic itself (truthy `[ -n "$STATUS" ]` exit) is left as-is — that's issue #4 and is intentionally out of scope here. `SKILL.md` section 6 still uses the global form as the canonical "track any process" example; left untouched on purpose so the generic guidance stays generic. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Gmulti
added a commit
that referenced
this pull request
Apr 30, 2026
fix: align safe-plugin-update Step 6 poll with project-scoped endpoint (#6)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Step 6 of the safe-plugin-update workflow polled the global
/processes?per_page=20while Step 7 read from/projects/<ID>/processes?per_page=20. Two problems:processId, two different endpoints.select(.id==$PROCESS_ID)then matches nothing,.code // emptyreturns empty, the poll never sees a terminal state, and the 2-minute loop times out reporting "still queued" even when the update finished in 10 seconds.The project-scoped endpoint avoids the page-1 race because per-project process volume is naturally much smaller, and it now matches Step 7.
Scope
Minimal — only the endpoint URL in Step 6. Two intentional non-changes:
[ -n "$STATUS" ]truthy exit) is safe-plugin-update polling exits early on any non-empty process code #4 and stays untouched here.SKILL.mdsection 6 still uses the global/processesform as the canonical "track any process" example. The generic guidance stays generic; the project-specific workflow uses the project-specific endpoint.Build verification
UMBRELLA_SKIP_COMPRESS=1 bash scripts/build.sh→✓ Build complete — 8 markdown file(s) copieddiff -r src/skills skills→ emptysrc/+ mirroredskills/), 4 lines totalTest plan
Closes #6.