Skip to content

Commit

Permalink
[THEMES-1884]Added check on credits length (#2077)
Browse files Browse the repository at this point in the history
* Bump @babel/preset-react from 7.23.3 to 7.24.1 (#2050)

Bumps [@babel/preset-react](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-react) from 7.23.3 to 7.24.1.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.24.1/packages/babel-preset-react)

---
updated-dependencies:
- dependency-name: "@babel/preset-react"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Added esc event listener to useEffect (#2044)

* Added esc event listener to useEffect

---------

Co-authored-by: Malavika Koppula <[email protected]>

* Added overflow to section-title links (#2027)

* Added flex to section-title links

---------

Co-authored-by: Malavika Koppula <[email protected]>

* Bump algoliasearch from 4.23.1 to 4.23.2 (#2057)

Bumps [algoliasearch](https://github.com/algolia/algoliasearch-client-javascript) from 4.23.1 to 4.23.2.
- [Release notes](https://github.com/algolia/algoliasearch-client-javascript/releases)
- [Changelog](https://github.com/algolia/algoliasearch-client-javascript/blob/master/CHANGELOG.md)
- [Commits](algolia/algoliasearch-client-javascript@4.23.1...4.23.2)

---
updated-dependencies:
- dependency-name: algoliasearch
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump eslint-plugin-react from 7.33.2 to 7.34.1 (#2062)

Bumps [eslint-plugin-react](https://github.com/jsx-eslint/eslint-plugin-react) from 7.33.2 to 7.34.1.
- [Release notes](https://github.com/jsx-eslint/eslint-plugin-react/releases)
- [Changelog](https://github.com/jsx-eslint/eslint-plugin-react/blob/v7.34.1/CHANGELOG.md)
- [Commits](jsx-eslint/eslint-plugin-react@v7.33.2...v7.34.1)

---
updated-dependencies:
- dependency-name: eslint-plugin-react
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump glob from 10.3.10 to 10.3.12 (#2063)

Bumps [glob](https://github.com/isaacs/node-glob) from 10.3.10 to 10.3.12.
- [Changelog](https://github.com/isaacs/node-glob/blob/main/changelog.md)
- [Commits](isaacs/node-glob@v10.3.10...v10.3.12)

---
updated-dependencies:
- dependency-name: glob
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Manual promo blocks now respect focal point (#1996)

* add focal point code and tests

* fix eslint errors

* fix formatting

* fix formatting p2

* shorten PR template based on eng sync discussions (#2065)

* Added check on credits length

* ASUB-8201 Sign In with Apple (#2067)

* Sign In with Apple

* fixing linting and tests

* fixing test & linting

* fixing linting errors

* removing update from  package.json

* fixing linting errors

* disable eslint warnings

* fixing warnings

* fixing sintax

* removing keys

* removing only

* fixing linting errors

* added dd-service-catalog.yml (#2089)

* added dd-service-catalog.yml

* updated infrastructure

* ASUB-8195 Sign up with reCaptcha (#2068)

* sign up with reCaptcha

* fixing linting and tests

* fixing linting errors

* fixing linting errors

* Lokalize-translation 2.3.0 (#2092)

* lokalize-translation 2.3.0

* attending feedback

* THEMES-1066: Update Storybook to v8 (#2090)

* THEMES-1066: updated versions of storybook and chromatic to the latest.

* THEMES-1066: fixed linting errors

* THEMES-1066 adjusted configs so that storybook could build without errors.

* THEMES-1066 remove addon-knobs

* THEMES-1066: removing more deprecated packages.

* THEMES-1066: added .babelrc

* THEMES-1066: moved babel config to main.js

* version bump

* added alias overrides

* Fixed intro page

* THEMES-1066: fixed webpack/babel config

* THEMES-1066: restore babel.config.js

* THEMES-1066: restore babel.config.js

* THEMES-1066: added styling storybook addon

* THEMES-1066: updated preview to just use news.scss

* THEMES-1066: fixed breaking stories and updated news.scss.

* THEMES-1066: version bump for storybook

* THEMES-1066: corrected whitespace

* THEMES-1066: Updating option for chromatic action.

* THEMES-1066: updated stylelint to hopefully fix the UI Tests check

* THEMES-1066: removed jsx from stylelint action input.

* THEMES-1066: added env vars to chromatic action

* THEMES-1066: removing test vars from workflow file.

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Malavika Koppula <[email protected]>
Co-authored-by: Anna Sherman <[email protected]>
Co-authored-by: LauraPinilla <[email protected]>
Co-authored-by: blakeganderson <[email protected]>
Co-authored-by: Vito Galatro <[email protected]>
  • Loading branch information
7 people authored May 16, 2024
1 parent 8d1883b commit 56f49d9
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ const MediumPromo = ({ customFields }) => {
return null;
}

const hasAuthors = showByline ? content?.credits?.by && content?.credits?.by.length : null;
const hasAuthors = showByline ? content?.credits?.by && content?.credits?.by?.length : null;
const contentDescription = showDescription ? content?.description?.basic : null;
const contentHeading = showHeadline ? content?.headlines?.basic : null;
const contentUrl = content?.websites?.[arcSite]?.website_url;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ const ExtraLarge = (props) => {
const contentHeading = showHeadlineXL ? element?.headlines?.basic : null;
const contentUrl = element?.websites?.[arcSite]?.website_url;
const embedMarkup = playVideoInPlaceXL && getVideoFromANS(element);
const hasAuthors = showBylineXL && element?.credits?.by.length > 0;
const hasAuthors = showBylineXL && element?.credits?.by?.length > 0;
const ansImage = getImageFromANS(element);
const imageParams =
element && ansImage
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ const Medium = (props) => {

const showBottomBorder = typeof showBottomBorderMD === "undefined" ? true : showBottomBorderMD;

const hasAuthors = showBylineMD ? element?.credits?.by && element?.credits?.by.length : null;
const hasAuthors = showBylineMD ? element?.credits?.by && element?.credits?.by?.length : null;
const contentDescription = showDescriptionMD ? element?.description?.basic : null;
const contentHeading = showHeadlineMD ? element?.headlines?.basic : null;
const contentUrl = element?.websites?.[arcSite]?.website_url;
Expand Down

0 comments on commit 56f49d9

Please sign in to comment.