Revert "Add editable headline and description for medium-promo-block" (…

…#2220)

Revert "Add editable headline and description for medium-promo-block (#2217)"

This reverts commit 9e56a21.

blocks/medium-promo-block/features/medium-promo/default.jsx

@@ -35,7 +35,7 @@ const BLOCK_CLASS_NAME = "b-medium-promo";
 const MediumPromo = ({ customFields }) => {
 	const { registerSuccessEvent } = useComponentContext();
 	const { arcSite, isAdmin } = useFusionContext();
-	const { editableContent, searchableField } = useEditableContent();
+	const { searchableField } = useEditableContent();
 	const {
 		dateLocalization: { language, timeZone, dateTimeFormat } = {
 			language: "en",
@@ -163,13 +163,7 @@ const MediumPromo = ({ customFields }) => {
 
 	const hasAuthors = showByline ? content?.credits?.by && content?.credits?.by?.length : null;
 	const contentDescription = showDescription ? content?.description?.basic : null;
-	const editableDescription = content?.description
-		? editableContent(content, "description.basic")
-		: {};
 	const contentHeading = showHeadline ? content?.headlines?.basic : null;
-	const editableHeading = content?.headlines?.basic
-		? editableContent(content, "headlines.basic")
-		: {};
 	const contentUrl = content?.websites?.[arcSite]?.website_url;
 
 	const contentDate = content?.display_date;
@@ -243,7 +237,7 @@ const MediumPromo = ({ customFields }) => {
 					) : null}
 
 					{contentHeading ? (
-						<Heading suppressContentEditableWarning {...editableHeading}>
+						<Heading>
 							<Conditional
 								component={Link}
 								condition={contentUrl}
@@ -255,11 +249,7 @@ const MediumPromo = ({ customFields }) => {
 						</Heading>
 					) : null}
 
-					{showDescription ? (
-						<Paragraph suppressContentEditableWarning {...editableDescription}>
-							{contentDescription}
-						</Paragraph>
-					) : null}
+					{showDescription ? <Paragraph>{contentDescription}</Paragraph> : null}
 					{hasAuthors || showDate ? (
 						<Attribution>
 							<Join separator={Separator}>

blocks/medium-promo-block/features/medium-promo/default.test.jsx

@@ -1,5 +1,4 @@
 import React from "react";
-import "@testing-library/jest-dom";
 import { render, screen } from "@testing-library/react";
 import { useContent } from "fusion:content";
 
@@ -28,18 +27,18 @@ describe("the medium promo feature", () => {
 		jest.clearAllMocks();
 	});
 
-	it("should not render if lazyLoad on the server and not in the admin", () => {
+	it("should return null if lazyLoad on the server and not in the admin", () => {
 		const config = {
 			lazyLoad: true,
 		};
-		render(<MediumPromo customFields={config} />);
-		expect(screen.queryByRole("article")).not.toBeInTheDocument();
+		const { container } = render(<MediumPromo customFields={config} />);
+		expect(container.firstChild).toBe(null);
 	});
 
-	it("should not render if none of the show... flags are true", () => {
+	it("should return null if none of the show... flags are true", () => {
 		const config = {};
-		render(<MediumPromo customFields={config} />);
-		expect(screen.queryByRole("article")).not.toBeInTheDocument();
+		const { container } = render(<MediumPromo customFields={config} />);
+		expect(container.firstChild).toBeNull();
 	});
 
 	it("should display a headline if showHeadline is true", () => {
@@ -48,27 +47,7 @@ describe("the medium promo feature", () => {
 		};
 		render(<MediumPromo customFields={config} />);
 
-		expect(screen.getByRole("heading", { name: mockData.headlines.basic })).not.toBeNull();
-	});
-
-	it("should headline be an editable field", () => {
-		const config = {
-			showHeadline: true,
-		};
-		render(<MediumPromo customFields={config} />);
-
-		expect(screen.queryByRole("heading", { name: mockData.headlines.basic })).toHaveAttribute(
-			"contenteditable",
-		);
-	});
-
-	it("should description be an editable field", () => {
-		const config = {
-			showDescription: true,
-		};
-		render(<MediumPromo customFields={config} />);
-
-		expect(screen.queryByText(mockData.description.basic)).toHaveAttribute("contenteditable");
+		expect(screen.queryByRole("heading", { name: config.headline })).not.toBeNull();
 	});
 
 	it("should display an image if showImage is true", () => {
@@ -78,7 +57,7 @@ describe("the medium promo feature", () => {
 			showImage: true,
 		};
 		render(<MediumPromo customFields={config} />);
-		expect(screen.getByRole("img", { name: config.headline })).not.toBeNull();
+		expect(screen.queryByRole("img", { name: config.headline })).not.toBeNull();
 	});
 
 	it("should make a blank call to the signing-service if the image is from PhotoCenter and has an Auth value", () => {
@@ -129,7 +108,7 @@ describe("the medium promo feature", () => {
 			showImage: true,
 		};
 		render(<MediumPromo customFields={config} />);
-		expect(screen.getByRole("img", { name: config.headline })).not.toBeNull();
+		expect(screen.queryByRole("img", { name: config.headline })).not.toBeNull();
 	});
 
 	it("should display a description if showDescription is true", () => {
@@ -138,19 +117,17 @@ describe("the medium promo feature", () => {
 		};
 		render(<MediumPromo customFields={config} />);
 		expect(
-			screen.getByText("Why does August seem hotter? Maybe it comes from weariness."),
+			screen.queryByText("Why does August seem hotter? Maybe it comes from weariness."),
 		).not.toBeNull();
 	});
 
 	it("should display a byline if showByline is true", () => {
 		const config = {
 			showByline: true,
 		};
-		render(<MediumPromo customFields={config} />);
+		const { getByText } = render(<MediumPromo customFields={config} />);
 		expect(
-			screen.getByText(
-				"global.by-text Example Author1, Example Author2, global.and-text Example Author3",
-			),
+			getByText("global.by-text Example Author1, Example Author2, global.and-text Example Author3"),
 		).not.toBeNull();
 	});
 
@@ -159,6 +136,6 @@ describe("the medium promo feature", () => {
 			showDate: true,
 		};
 		render(<MediumPromo customFields={config} />);
-		expect(screen.getByText("January 30, 2020", { exact: false })).not.toBeNull();
+		expect(screen.queryByText("January 30, 2020", { exact: false })).not.toBeNull();
 	});
 });