Subscriptions blocks v2 #1768

LauraPinilla · 2023-11-02T19:39:15Z

If you have not filled out the checklist below, the pr is not ready for review.

Description

Migrate Subscriptions blocks from v1 to v2

Note:
I was unable to grab the getSignedInIdentity() from useIdentity(). useIdentity only is returning Identity & isInitialized. Not sure why the function is not returned, I can see everything is ok on Identity-block. Do you mind taking a look into this?
And for this reason, I re-write the function here.

Jira Ticket

https://arcpublishing.atlassian.net/browse/ASUB-7843
https://arcpublishing.atlassian.net/browse/ASUB-7842
https://arcpublishing.atlassian.net/browse/ASUB-7901 >> Minor change, reported on identity block for Signup

Acceptance Criteria

Checkout & offers working

Test Steps

Add test steps a reviewer must complete to test this PR

Checkout this branch git checkout Subscriptions_blocks_v2
Include @wpmedia/subscriptions-block inside blocks.json (fusion repo)
Run fusion repo with linked blocks npx fusion start -f -l @wpmedia/subscriptions-block

I just added a payment provider to your testing org.
This block has a different behavior depending if the user is logged In or not.

Pages needed:
Login page
checkout page. This page will contain the checkout component. offerURL: “link to offer page”
offer page. This page will contain the offer component.

Step 1: The user is logged In and redirected to the offer page
Step 2: Go into the offer page
Step 3: Select an item

Note: The icon for each item should be a checkbox icon. We will change this once themes team completes this
Step 4. On checkout, you will be able to see the contact Info, and the items into the cart.
Include the country: e.g. US, MX,
Note: The country or region should be a dropdown. We will change this once themes team completes this
Click on checkout

Step 5. Enter the payment info & click on purchase subscription
For now we have stripe intents as the payment provider. You can use
cardNumber: 4242 4242 4242 4242
MM/YY: 12/24
cvc: 123
zip: 45610

You should be redirected to the success URL
You will be able to see the subscription and order on Subs app, by searching for your user.

Also, if you are an anonymous user, when you fall in offers and you select an item, you should be redirected to the login page, and once you are logged In you can continue with the checkout process

Effect Of Changes

Before

Example: When I clicked the search button, the button turned red.

[include screenshot or gif or link to video, storybook would be awesome]

After

Example: When I clicked the search button, the button turned green.

[include screenshot or gif or link to video, storybook would be awesome]

Dependencies or Side Effects

Examples of dependencies or side effects are:

Manifest pr for new block:
Feature pack pr for local development:
How to deploy to news: https://arcpublishing.atlassian.net/wiki/spaces/TI/pages/3138682964/News+Theme+2.0+Migration+Development+Deployment+Notes
Additional settings that will be required in the blocks.json
Changes to the custom fields which will require users to reconfigure features
Dependency on another PR that needs to be merged first

Author Checklist

The author of the PR should fill out the following sections to ensure this PR is ready for review.

Confirmed all the test steps a reviewer will follow above are working.
Confirmed there are no linter errors. Please run npm run lint to check for errors. Often, npm run lint:fix will fix those errors and warnings.
Ran this code locally and checked that there are not any unintended side effects. For example, that a CSS selector is scoped only to a particular block.
Confirmed this PR has reasonable code coverage. You can run npm run test:coverage to see your progress.
- Confirmed this PR has unit test files
- Ran npm run test, made sure all tests are passing
- If the amount of work to write unit tests for this change are excessive,
  please explain why (so that we can fix it whenever it gets refactored).
Confirmed relevant documentation has been updated/added.

Reviewer Checklist

The reviewer of the PR should copy-paste this template into the review comments on review.

Linting code actions have passed.
Ran the code locally based on the test instructions.
- I don’t think this is needed to be tested locally. For example, a padding style change (storybook?) or a logic change (write a test).
I am a member of the engine theme team so that I can approve and merge this. If you're not on the team, you won't have access to approve and merge this pr.
Looked to see that the new or changed code has code coverage, specifically. We want the global code coverage to keep on going up with targeted testing.

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

stylelint

blocks/subscriptions-block/_index.scss|53 col 3| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|54 col 4| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|55 col 4| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|57 col 4| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|58 col 5| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|59 col 5| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|64 col 2| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|65 col 2| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|69 col 2| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|70 col 3| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|71 col 3| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|74 col 2| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|75 col 3| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|76 col 3| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|79 col 2| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|80 col 3| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|81 col 3| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|84 col 2| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|85 col 3| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|86 col 3| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|89 col 2| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|90 col 3| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|91 col 3| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|93 col 3| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|94 col 4| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|95 col 4| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|98 col 3| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|99 col 4| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|100 col 4| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|103 col 3| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|104 col 4| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|105 col 4| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|108 col 3| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|109 col 4| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|110 col 4| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|113 col 3| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|114 col 4| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|115 col 4| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|117 col 4| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|118 col 5| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|119 col 5| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|124 col 2| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|125 col 3| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|126 col 3| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|129 col 2| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|130 col 3| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|131 col 3| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|134 col 2| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|135 col 3| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|136 col 3| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|139 col 2| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|140 col 2| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|1 col 1| Unknown rule order/properties-alphabetical-order. order/properties-alphabetical-order
blocks/subscriptions-block/_index.scss|1 col 1| Unknown rule order/order. order/order
blocks/subscriptions-block/components/useOffer.jsx|1 col 10| Unknown word (CssSyntaxError) CssSyntaxError
blocks/subscriptions-block/components/useOffer.test.jsx|2 col 2| Unknown word (CssSyntaxError) CssSyntaxError
blocks/subscriptions-block/components/useSales.jsx|1 col 10| Unknown word (CssSyntaxError) CssSyntaxError
blocks/subscriptions-block/components/useSales.test.jsx|1 col 1| Unknown word (CssSyntaxError) CssSyntaxError
blocks/subscriptions-block/utils/currency.test.jsx|1 col 1| Unknown word (CssSyntaxError) CssSyntaxError
blocks/subscriptions-block/components/Cart/index.jsx|1 col 17| Unknown word (CssSyntaxError) CssSyntaxError
blocks/subscriptions-block/components/Cart/index.test.jsx|1 col 1| Unknown word (CssSyntaxError) CssSyntaxError
blocks/subscriptions-block/components/Cart/item.jsx|1 col 1| Unknown word (CssSyntaxError) CssSyntaxError
blocks/subscriptions-block/components/Cart/item.test.jsx|1 col 1| Unknown word (CssSyntaxError) CssSyntaxError
blocks/subscriptions-block/components/ContactInfo/index.jsx|1 col 17| Unknown word (CssSyntaxError) CssSyntaxError
blocks/subscriptions-block/components/ContactInfo/index.story-ignore.jsx|1 col 1| Unknown word (CssSyntaxError) CssSyntaxError
blocks/subscriptions-block/components/ContactInfo/index.test.jsx|1 col 1| Unknown word (CssSyntaxError) CssSyntaxError
blocks/subscriptions-block/components/GridList/index.jsx|1 col 1| Unknown word (CssSyntaxError) CssSyntaxError
blocks/subscriptions-block/components/GridList/index.story-ignore.jsx|1 col 1| Unknown word (CssSyntaxError) CssSyntaxError
blocks/subscriptions-block/components/GridList/index.test.jsx|1 col 1| Unknown word (CssSyntaxError) CssSyntaxError
blocks/subscriptions-block/components/OfferCard/index.jsx|1 col 1| Unknown word (CssSyntaxError) CssSyntaxError
blocks/subscriptions-block/components/OfferCard/index.story-ignore.jsx|1 col 1| Unknown word (CssSyntaxError) CssSyntaxError
blocks/subscriptions-block/components/OfferCard/index.test.jsx|1 col 1| Unknown word (CssSyntaxError) CssSyntaxError
blocks/subscriptions-block/components/OfferToProductList/index.jsx|1 col 1| Unknown word (CssSyntaxError) CssSyntaxError
blocks/subscriptions-block/components/OfferToProductList/index.test.jsx|1 col 1| Unknown word (CssSyntaxError) CssSyntaxError
blocks/subscriptions-block/components/PaymentForm/index.jsx|1 col 17| Unknown word (CssSyntaxError) CssSyntaxError
blocks/subscriptions-block/components/PaymentForm/index.story-ignore.jsx|1 col 1| Unknown word (CssSyntaxError) CssSyntaxError
blocks/subscriptions-block/components/PaymentForm/index.test.jsx|1 col 1| Unknown word (CssSyntaxError) CssSyntaxError
blocks/subscriptions-block/features/checkout/default.jsx|1 col 17| Unknown word (CssSyntaxError) CssSyntaxError
blocks/subscriptions-block/features/checkout/default.test.jsx|1 col 1| Unknown word (CssSyntaxError) CssSyntaxError
blocks/subscriptions-block/features/offer/default.jsx|1 col 17| Unknown word (CssSyntaxError) CssSyntaxError
blocks/subscriptions-block/features/offer/default.test.jsx|1 col 1| Unknown word (CssSyntaxError) CssSyntaxError
blocks/subscriptions-block/features/checkout/_children/PaymentInfo/index.jsx|1 col 17| Unknown word (CssSyntaxError) CssSyntaxError

blocks/subscriptions-block/_index.scss

nschubach · 2023-11-07T15:23:36Z

Is this ready for review @LauraPinilla ?

LauraPinilla · 2023-11-07T17:36:37Z

Is this ready for review @LauraPinilla ?

Yes, It's ready for review. It only contains offer & checkout.
A single comment, on localhost I was unable to grab getSignedInIdentity() from Identity, not sure why, if you can take a look.

vgalatro · 2023-11-08T17:36:35Z

@LauraPinilla , so you are saying const { Identity, getSignedInIdentity } = useIdentity(); was not working at all for you? Currently it's only used in unit testing, but it does get passed through there.

vgalatro · 2023-11-08T17:41:22Z

Also @LauraPinilla , can you include some more testing/setup instructions? I'm not really sure what these blocks should be doing. We have subs provisioned for our test environments so just some guidance and what needs to be set there would be helpful.

LauraPinilla · 2023-11-08T17:57:34Z

@LauraPinilla , so you are saying const { Identity, getSignedInIdentity } = useIdentity(); was not working at all for you? Currently it's only used in unit testing, but it does get passed through there.

By checking the useIdentity() hook this should be retuning Identity, isInitialized, and getSignedInIdentity. But unable to get the getSignedInIdentity function.

vgalatro · 2023-11-08T18:27:24Z

@LauraPinilla , I see what is happening. Fusion CLI is installing a very old version of the identity-block in the node_modules folder within the subs block. So it's using that code instead. I also realized we'll need an index.js in the identity block to actually export the useIdentity hook so the subs block could use it. Although it would be preferred that anything shared between blocks is in arc-themes-components, these two blocks are so tightly coupled anyway it should be fine.

vgalatro · 2023-11-08T18:36:53Z

I was able to work around that issue by putting an index.js at the root of arc-themes-blocks/identity-block with the following:

import useIdentity from "./components/identity";

export {
	// eslint-disable-next-line import/prefer-default-export
	useIdentity,
};

I ran fusion with both blocks linked npx fusion start -f -l @wpmedia/subscriptions-block,@wpmedia/identity-block. And deleted the node_modules folder that got put into arc-themes-blocks/subscriptions-block. You may have to run npx fusion rebuild in another terminal window to get it fully working.

That index.js can be added to the identity block as a part of this PR, since it's a necessary change for the subs blocks.

vgalatro · 2023-11-08T18:03:35Z

blocks/subscriptions-block/features/checkout/default.jsx

+	}),
+};
+
+Checkout.label = "Checkout - Arc Block";


Adding Subscriptions or Subs to the beginning of the label would be helpful, so it's easier to identify in the list of blocks a user is presented with. Since they get listed alphabetically, it will also keep all of the related blocks grouped together. This applies to the offer block as well.

I prefer the long form, abbreviations could be misinterpreted. Can't think of what ATM, and all I can think about is submarine sandwiches, but still.

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

stylelint

blocks/subscriptions-block/_index.scss|104 col 4| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|105 col 4| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|108 col 3| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|109 col 4| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|110 col 4| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|113 col 3| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|114 col 4| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|115 col 4| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|117 col 4| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|118 col 5| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|119 col 5| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|124 col 2| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|125 col 3| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|126 col 3| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|129 col 2| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|130 col 3| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|131 col 3| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|134 col 2| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|135 col 3| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|136 col 3| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|139 col 2| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|140 col 2| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|1 col 1| Unknown rule order/properties-alphabetical-order. order/properties-alphabetical-order
blocks/subscriptions-block/_index.scss|1 col 1| Unknown rule order/order. order/order
blocks/subscriptions-block/components/useOffer.jsx|1 col 10| Unknown word (CssSyntaxError) CssSyntaxError
blocks/subscriptions-block/components/useOffer.test.jsx|2 col 2| Unknown word (CssSyntaxError) CssSyntaxError
blocks/subscriptions-block/components/useSales.jsx|1 col 10| Unknown word (CssSyntaxError) CssSyntaxError
blocks/subscriptions-block/components/useSales.test.jsx|1 col 1| Unknown word (CssSyntaxError) CssSyntaxError
blocks/subscriptions-block/utils/currency.test.jsx|1 col 1| Unknown word (CssSyntaxError) CssSyntaxError
blocks/subscriptions-block/components/Cart/index.jsx|1 col 17| Unknown word (CssSyntaxError) CssSyntaxError
blocks/subscriptions-block/components/Cart/index.test.jsx|1 col 1| Unknown word (CssSyntaxError) CssSyntaxError
blocks/subscriptions-block/components/Cart/item.jsx|1 col 1| Unknown word (CssSyntaxError) CssSyntaxError
blocks/subscriptions-block/components/Cart/item.test.jsx|1 col 1| Unknown word (CssSyntaxError) CssSyntaxError
blocks/subscriptions-block/components/ContactInfo/index.jsx|1 col 17| Unknown word (CssSyntaxError) CssSyntaxError
blocks/subscriptions-block/components/ContactInfo/index.story-ignore.jsx|1 col 1| Unknown word (CssSyntaxError) CssSyntaxError
blocks/subscriptions-block/components/ContactInfo/index.test.jsx|1 col 1| Unknown word (CssSyntaxError) CssSyntaxError
blocks/subscriptions-block/components/GridList/index.jsx|1 col 1| Unknown word (CssSyntaxError) CssSyntaxError
blocks/subscriptions-block/components/GridList/index.story-ignore.jsx|1 col 1| Unknown word (CssSyntaxError) CssSyntaxError
blocks/subscriptions-block/components/GridList/index.test.jsx|1 col 1| Unknown word (CssSyntaxError) CssSyntaxError
blocks/subscriptions-block/components/OfferCard/index.jsx|1 col 1| Unknown word (CssSyntaxError) CssSyntaxError
blocks/subscriptions-block/components/OfferCard/index.story-ignore.jsx|1 col 1| Unknown word (CssSyntaxError) CssSyntaxError
blocks/subscriptions-block/components/OfferCard/index.test.jsx|1 col 1| Unknown word (CssSyntaxError) CssSyntaxError
blocks/subscriptions-block/components/OfferToProductList/index.jsx|1 col 1| Unknown word (CssSyntaxError) CssSyntaxError
blocks/subscriptions-block/components/OfferToProductList/index.test.jsx|1 col 1| Unknown word (CssSyntaxError) CssSyntaxError
blocks/subscriptions-block/components/PaymentForm/index.jsx|1 col 17| Unknown word (CssSyntaxError) CssSyntaxError
blocks/subscriptions-block/components/PaymentForm/index.story-ignore.jsx|1 col 1| Unknown word (CssSyntaxError) CssSyntaxError
blocks/subscriptions-block/components/PaymentForm/index.test.jsx|1 col 1| Unknown word (CssSyntaxError) CssSyntaxError
blocks/subscriptions-block/features/checkout/default.jsx|1 col 17| Unknown word (CssSyntaxError) CssSyntaxError
blocks/subscriptions-block/features/checkout/default.test.jsx|1 col 1| Unknown word (CssSyntaxError) CssSyntaxError
blocks/subscriptions-block/features/offer/default.jsx|1 col 17| Unknown word (CssSyntaxError) CssSyntaxError
blocks/subscriptions-block/features/offer/default.test.jsx|1 col 1| Unknown word (CssSyntaxError) CssSyntaxError
blocks/subscriptions-block/features/checkout/_children/PaymentInfo/index.jsx|1 col 17| Unknown word (CssSyntaxError) CssSyntaxError

blocks/subscriptions-block/_index.scss

vgalatro · 2023-11-09T17:30:08Z

@LauraPinilla , I set up a test offer here https://themesinternal.arcpublishing.com/subscriptions/retail/offers?site=the-gazette and I'm using https://themesinternal-the-gazette-prod.api.cdn.arcpublishing.com as my api.retail.origin in the site properties, but I'm not seeing the offer in the block. Is there some other setup needed?

I'm not seeing any error messages either.

LauraPinilla · 2023-11-09T18:15:58Z

@LauraPinilla , I set up a test offer here https://themesinternal.arcpublishing.com/subscriptions/retail/offers?site=the-gazette and I'm using https://themesinternal-the-gazette-prod.api.cdn.arcpublishing.com as my api.retail.origin in the site properties, but I'm not seeing the offer in the block. Is there some other setup needed?

I'm not seeing any error messages either.

Could you try again?
You will need to set the offer as default offer. I did this for you

vgalatro

The functionality is all there, which is great! There's just some cleanup that can be done as well. I'll check in with our PO and make sure the icon updates are prioritized, so maybe there won't need to be a follow up ticket to add the checkbox/Google logo after the fact.

blocks/subscriptions-block/components/PaymentForm/index.jsx

blocks/subscriptions-block/components/Cart/index.jsx

vgalatro · 2023-11-10T20:14:11Z

blocks/subscriptions-block/components/Cart/index.test.jsx

@@ -0,0 +1,156 @@
+import React from "react";
+import { mount } from "enzyme";


Tests in our repos can't use enzyme moving forward, due to incompatibility with Node v16. Can you at least remove the references to enzyme (and mount). Ideally these should all be converted to use @testing-library/react, but there are issues running the tests currently in this repo so that can be a follow-up task.

This will apply to all test files.

blocks/subscriptions-block/intl.json

blocks/subscriptions-block/themes/news.json

vgalatro · 2023-11-10T20:38:20Z

blocks/subscriptions-block/components/ContactInfo/index.jsx

+import GoogleIcon from "./google.svg";
+import FacebookIcon from "./facebook.svg";


There shouldn't be svgs included like this. For Facebook at least there's an icon in the Icon component. I can add a Google logo to the ticket to update that component (for the checkmark and the other missing icons) as well.

@vgalatro I changed the Image for facebook, but for now I will keep the google until the icon on themes-components is done

@vgalatro For that Google Icon ticket, just a heads up
https://developers.google.com/identity/branding-guidelines#incorrect-button-design

I noticed the v2 icons are all monochrome black & white. Google explicitly requires the full color version of the icon.

For Facebook, could we be provided a color version, with the Facebook blue? Facebook allows a black version of the logo, but only for technical reasons.
https://developers.facebook.com/docs/facebook-login/userexperience/#buttondesign

LMK if I should file a ticket instead

@mattkim93 , the v2 icons all accept a fill color as a parameter, so they can be any single color. If there is no fill set in the code they can also be styled with CSS. But you are right, we'll need a specific one for the multi-color Google logo. I've made an update in the ticket we're using to track that work.

blocks/subscriptions-block/components/OfferToProductList/index.jsx

blocks/subscriptions-block/components/useOffer.jsx

blocks/subscriptions-block/components/useSales.jsx

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

stylelint

blocks/subscriptions-block/_index.scss|113 col 3| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|114 col 4| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|115 col 4| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|118 col 3| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|119 col 4| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|120 col 4| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|149 col 2| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|150 col 3| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|151 col 3| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|169 col 4| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|170 col 4| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|173 col 3| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|174 col 4| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|175 col 4| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|178 col 3| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|179 col 4| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|180 col 4| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|182 col 4| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|183 col 5| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|184 col 5| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|189 col 2| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|190 col 3| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|191 col 3| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|194 col 2| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|195 col 3| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|196 col 3| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|199 col 2| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|200 col 3| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|201 col 3| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|204 col 2| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|205 col 2| Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
blocks/subscriptions-block/_index.scss|1 col 1| Unknown rule order/properties-alphabetical-order. order/properties-alphabetical-order
blocks/subscriptions-block/_index.scss|1 col 1| Unknown rule order/order. order/order
blocks/subscriptions-block/components/useOffer.jsx|1 col 10| Unknown word (CssSyntaxError) CssSyntaxError
blocks/subscriptions-block/components/useOffer.test.jsx|2 col 2| Unknown word (CssSyntaxError) CssSyntaxError
blocks/subscriptions-block/components/useSales.jsx|1 col 10| Unknown word (CssSyntaxError) CssSyntaxError
blocks/subscriptions-block/components/useSales.test.jsx|1 col 1| Unknown word (CssSyntaxError) CssSyntaxError
blocks/subscriptions-block/utils/currency.test.jsx|1 col 1| Unknown word (CssSyntaxError) CssSyntaxError
blocks/subscriptions-block/components/Cart/index.jsx|1 col 17| Unknown word (CssSyntaxError) CssSyntaxError
blocks/subscriptions-block/components/Cart/index.test.jsx|1 col 1| Unknown word (CssSyntaxError) CssSyntaxError
blocks/subscriptions-block/components/Cart/item.jsx|1 col 1| Unknown word (CssSyntaxError) CssSyntaxError
blocks/subscriptions-block/components/Cart/item.test.jsx|1 col 1| Unknown word (CssSyntaxError) CssSyntaxError
blocks/subscriptions-block/components/ContactInfo/index.jsx|1 col 17| Unknown word (CssSyntaxError) CssSyntaxError
blocks/subscriptions-block/components/ContactInfo/index.story-ignore.jsx|1 col 1| Unknown word (CssSyntaxError) CssSyntaxError
blocks/subscriptions-block/components/ContactInfo/index.test.jsx|1 col 1| Unknown word (CssSyntaxError) CssSyntaxError
blocks/subscriptions-block/components/OfferCard/index.jsx|1 col 1| Unknown word (CssSyntaxError) CssSyntaxError
blocks/subscriptions-block/components/OfferCard/index.story-ignore.jsx|1 col 1| Unknown word (CssSyntaxError) CssSyntaxError
blocks/subscriptions-block/components/OfferCard/index.test.jsx|1 col 1| Unknown word (CssSyntaxError) CssSyntaxError
blocks/subscriptions-block/components/OfferToProductList/index.jsx|1 col 1| Unknown word (CssSyntaxError) CssSyntaxError
blocks/subscriptions-block/components/OfferToProductList/index.test.jsx|1 col 1| Unknown word (CssSyntaxError) CssSyntaxError
blocks/subscriptions-block/components/PaymentForm/index.jsx|1 col 17| Unknown word (CssSyntaxError) CssSyntaxError
blocks/subscriptions-block/components/PaymentForm/index.story-ignore.jsx|1 col 1| Unknown word (CssSyntaxError) CssSyntaxError
blocks/subscriptions-block/components/PaymentForm/index.test.jsx|1 col 1| Unknown word (CssSyntaxError) CssSyntaxError
blocks/subscriptions-block/features/checkout/default.jsx|1 col 17| Unknown word (CssSyntaxError) CssSyntaxError
blocks/subscriptions-block/features/checkout/default.test.jsx|1 col 1| Unknown word (CssSyntaxError) CssSyntaxError
blocks/subscriptions-block/features/offer/default.jsx|1 col 17| Unknown word (CssSyntaxError) CssSyntaxError
blocks/subscriptions-block/features/offer/default.test.jsx|1 col 1| Unknown word (CssSyntaxError) CssSyntaxError
blocks/subscriptions-block/features/checkout/_children/PaymentInfo/index.jsx|1 col 17| Unknown word (CssSyntaxError) CssSyntaxError

blocks/subscriptions-block/_index.scss

…ocks_v2

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

stylelint

blocks/subscriptions-block/_index.scss

blocks/subscriptions-block/components/useOffer.jsx

blocks/subscriptions-block/components/useOffer.test.jsx

blocks/subscriptions-block/features/checkout/default.jsx

blocks/subscriptions-block/features/checkout/default.test.jsx

blocks/subscriptions-block/features/offer/default.jsx

blocks/subscriptions-block/features/offer/default.test.jsx

blocks/subscriptions-block/features/checkout/_children/PaymentInfo/index.jsx

mattkim93

Hey, just one change request for the Facebook Logo.
The Google one looks like it's correct, but could you just confirm with the guidelines here? https://developers.google.com/identity/branding-guidelines

mattkim93 · 2023-11-14T21:18:13Z

blocks/subscriptions-block/components/ContactInfo/facebook.svg

Can we use the logo provided here instead?
https://about.meta.com/brand/resources/facebook/logo/

…ocks_v2

vgalatro · 2023-11-15T18:43:10Z

blocks/subscriptions-block/components/ContactInfo/index.jsx

+				case "facebook":
+					return (
+						<div className={`${className}__identity-row`}>
+							<Icon name="Facebook"/>


@LauraPinilla , should be a quick update, but you will want to set the fill prop here, with the Facebook blue (I think it's #415993).

As I'm working on the icons ticket, I'm noticing this prop is not functioning. You can set the fill via CSS (with a token specific to this Facebook icon) as a workaround for now.

vgalatro · 2023-11-15T18:51:52Z

blocks/subscriptions-block/components/ContactInfo/index.jsx

+					validationErrorMessage={phrases.t("checkout-block.last-name-requirements")}
+				/>
+			</div>
+			<Input


@LauraPinilla , I just merged in the dropdown changes to arc-themes-components-version-2.1.2, so if you pull down that branch locally you can update this input. You just need to change the type to select and add an array of options objects like so:

options={[ { label: 'Option 1', value: 'option1' }, { label: 'Option 2', value: 'option2' }, ]}

You can also set the optionLabelKey and optionValueKey props to key and code respectively, to use the country codes in countryCodes.js. Just pass the key value through phrases.t() first.

vgalatro

@LauraPinilla , the changes made look good, but I noticed one more small issue, and the dropdown can be implemented now. Just make sure you are linking arc-theme-components locally (with the THEME_COMPONENTS_REPO value in the feature pack .env) and it's checked out to arc-themes-release-version-2.1.2.

…es-blocks into Subscriptions_blocks_v2

vgalatro

Changes look good. Just noting that styling corrections that are needed will be done as a follow up task.

LauraPinilla added 2 commits November 2, 2023 12:55

Subscriptions block

98dfb80

chromatic

dca0001

LauraPinilla requested a review from a team as a code owner November 2, 2023 19:39

github-actions bot reviewed Nov 2, 2023

View reviewed changes

LauraPinilla added WIP Work in progress. Feel free to give feedback, but no formal review is requested at this time. and removed WIP Work in progress. Feel free to give feedback, but no formal review is requested at this time. labels Nov 2, 2023

LauraPinilla added question Further information is requested for the PR author ready for review The PR author has completed the PR template and is ready for a review labels Nov 7, 2023

vgalatro self-assigned this Nov 8, 2023

vgalatro reviewed Nov 8, 2023

View reviewed changes

Attending feedback and fixing bug when cart is empty

0bc8627

github-actions bot reviewed Nov 8, 2023

View reviewed changes

LauraPinilla removed the question Further information is requested for the PR author label Nov 9, 2023

vgalatro suggested changes Nov 10, 2023

View reviewed changes

vgalatro added needs changes The reviewer has requested changes from the PR author and removed ready for review The PR author has completed the PR template and is ready for a review labels Nov 10, 2023

attending feedback

7aa64f2

github-actions bot reviewed Nov 14, 2023

View reviewed changes

Merge branch 'arc-themes-release-version-2.1.1' into Subscriptions_bl…

7e25ac8

…ocks_v2

github-actions bot reviewed Nov 14, 2023

View reviewed changes

attending feedback, styles in commerce.json

f0e4726

github-actions bot reviewed Nov 14, 2023

View reviewed changes

mattkim93 requested changes Nov 14, 2023

View reviewed changes

mattkim93 requested review from nschubach and vgalatro November 14, 2023 21:21

LauraPinilla removed the needs changes The reviewer has requested changes from the PR author label Nov 14, 2023

using the past midnight date

26671e2

vgalatro added review in progress A review is underway. Even if an approval has been submitted, wait for all reviews to be completed. and removed ready for review The PR author has completed the PR template and is ready for a review labels Nov 15, 2023

vgalatro changed the base branch from arc-themes-release-version-2.1.1 to arc-themes-release-version-2.1.2 November 15, 2023 17:34

Merge branch 'arc-themes-release-version-2.1.2' into Subscriptions_bl…

0b86cd0

…ocks_v2

vgalatro reviewed Nov 15, 2023

View reviewed changes

vgalatro suggested changes Nov 15, 2023

View reviewed changes

LauraPinilla added 2 commits November 15, 2023 13:53

attending feedback selector and fb icon color

d414fec

Merge branch 'Subscriptions_blocks_v2' of github.com:WPMedia/arc-them…

727d0c5

…es-blocks into Subscriptions_blocks_v2

vgalatro approved these changes Nov 15, 2023

View reviewed changes

vgalatro added ready to merge It's time! Merge this PR. Woo! and removed review in progress A review is underway. Even if an approval has been submitted, wait for all reviews to be completed. labels Nov 15, 2023

vgalatro merged commit 4bff519 into arc-themes-release-version-2.1.2 Nov 15, 2023
3 of 6 checks passed

vgalatro deleted the Subscriptions_blocks_v2 branch November 15, 2023 20:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Subscriptions blocks v2 #1768

Subscriptions blocks v2 #1768

LauraPinilla commented Nov 2, 2023 •

edited

Loading

github-actions bot left a comment

nschubach commented Nov 7, 2023

LauraPinilla commented Nov 7, 2023

vgalatro commented Nov 8, 2023

vgalatro commented Nov 8, 2023

LauraPinilla commented Nov 8, 2023

vgalatro commented Nov 8, 2023

vgalatro commented Nov 8, 2023

vgalatro Nov 8, 2023

nschubach Nov 9, 2023

github-actions bot left a comment

vgalatro commented Nov 9, 2023 •

edited

Loading

LauraPinilla commented Nov 9, 2023

vgalatro left a comment

vgalatro Nov 10, 2023

vgalatro Nov 10, 2023

vgalatro Nov 10, 2023

LauraPinilla Nov 14, 2023

mattkim93 Nov 14, 2023

vgalatro Nov 14, 2023

github-actions bot left a comment

github-actions bot left a comment

mattkim93 left a comment

mattkim93 Nov 14, 2023

vgalatro Nov 15, 2023

vgalatro Nov 15, 2023

vgalatro Nov 15, 2023

vgalatro Nov 15, 2023

vgalatro Nov 15, 2023

vgalatro left a comment

vgalatro left a comment

		@@ -0,0 +1,156 @@
		import React from "react";
		import { mount } from "enzyme";

		import GoogleIcon from "./google.svg";
		import FacebookIcon from "./facebook.svg";

Subscriptions blocks v2 #1768

Subscriptions blocks v2 #1768

Conversation

LauraPinilla commented Nov 2, 2023 • edited Loading

Description

Jira Ticket

Acceptance Criteria

Test Steps

Effect Of Changes

Before

After

Dependencies or Side Effects

Author Checklist

Reviewer Checklist

github-actions bot left a comment

Choose a reason for hiding this comment

nschubach commented Nov 7, 2023

LauraPinilla commented Nov 7, 2023

vgalatro commented Nov 8, 2023

vgalatro commented Nov 8, 2023

LauraPinilla commented Nov 8, 2023

vgalatro commented Nov 8, 2023

vgalatro commented Nov 8, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

vgalatro commented Nov 9, 2023 • edited Loading

LauraPinilla commented Nov 9, 2023

vgalatro left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

mattkim93 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vgalatro left a comment

Choose a reason for hiding this comment

vgalatro left a comment

Choose a reason for hiding this comment

LauraPinilla commented Nov 2, 2023 •

edited

Loading

vgalatro commented Nov 9, 2023 •

edited

Loading