ASUB-7844 PayPal block #1806

edwardcho1231 · 2023-11-22T15:52:32Z

If you have not filled out the checklist below, the pr is not ready for review.

Description

Information about what you changed for this PR

Jira Ticket

THEMES-

Acceptance Criteria

copy from ticket

Test Steps

Add test steps a reviewer must complete to test this PR

Checkout this branch git checkout {branch name}
Run fusion repo with linked blocks npx fusion start -f -l {blocks to link}
{Next ....}

Effect Of Changes

Before

Example: When I clicked the search button, the button turned red.

[include screenshot or gif or link to video, storybook would be awesome]

After

Example: When I clicked the search button, the button turned green.

[include screenshot or gif or link to video, storybook would be awesome]

Dependencies or Side Effects

Examples of dependencies or side effects are:

Manifest pr for new block:
Feature pack pr for local development:
How to deploy to news: https://arcpublishing.atlassian.net/wiki/spaces/TI/pages/3138682964/News+Theme+2.0+Migration+Development+Deployment+Notes
Additional settings that will be required in the blocks.json
Changes to the custom fields which will require users to reconfigure features
Dependency on another PR that needs to be merged first

Author Checklist

The author of the PR should fill out the following sections to ensure this PR is ready for review.

Confirmed all the test steps a reviewer will follow above are working.
Confirmed there are no linter errors. Please run npm run lint to check for errors. Often, npm run lint:fix will fix those errors and warnings.
Ran this code locally and checked that there are not any unintended side effects. For example, that a CSS selector is scoped only to a particular block.
Confirmed this PR has reasonable code coverage. You can run npm run test:coverage to see your progress.
- Confirmed this PR has unit test files
- Ran npm run test, made sure all tests are passing
- If the amount of work to write unit tests for this change are excessive,
  please explain why (so that we can fix it whenever it gets refactored).
Confirmed relevant documentation has been updated/added.

Reviewer Checklist

The reviewer of the PR should copy-paste this template into the review comments on review.

Linting code actions have passed.
Ran the code locally based on the test instructions.
- I don’t think this is needed to be tested locally. For example, a padding style change (storybook?) or a logic change (write a test).
I am a member of the engine theme team so that I can approve and merge this. If you're not on the team, you won't have access to approve and merge this pr.
Looked to see that the new or changed code has code coverage, specifically. We want the global code coverage to keep on going up with targeted testing.

github-actions · 2023-11-22T15:53:07Z

blocks/subscriptions-block/features/checkout/_children/PaymentInfo/index.jsx

@@ -1,17 +1,22 @@
-import React, { useEffect, useState } from "react";
+import React, { useEffect, useState, useMemo } from "react";


🚫 [stylelint] _{reported by reviewdog 🐶}
Unknown word (CssSyntaxError) CssSyntaxError

github-actions · 2023-11-27T15:05:51Z

blocks/subscriptions-block/components/usePaymentRedirect.jsx

@@ -0,0 +1,105 @@
+import { useState, useEffect } from 'react';


🚫 [stylelint] _{reported by reviewdog 🐶}
Unknown word (CssSyntaxError) CssSyntaxError

blocks/subscriptions-block/components/PayPal/index.jsx

github-actions · 2023-11-27T15:05:51Z

blocks/subscriptions-block/features/checkout/default.jsx

@@ -1,4 +1,4 @@
-import React, { useEffect, useState } from "react";
+import React, { useEffect, useState, useMemo } from "react";


🚫 [stylelint] _{reported by reviewdog 🐶}
Unknown word (CssSyntaxError) CssSyntaxError

blocks/subscriptions-block/features/checkout/_children/PaymentInfo/index.jsx

blocks/subscriptions-block/components/usePaymentRedirect.jsx

blocks/subscriptions-block/_index.scss

github-actions · 2023-11-28T20:17:35Z

blocks/subscriptions-block/_index.scss

@@ -50,6 +50,11 @@
 		@include scss.block-components("checkout-payment");
 		@include scss.block-properties("checkout-payment");

+		&-info {
+			@include scss.block-compoents("checkout-payment-info");


⚠️ [stylelint] _{reported by reviewdog 🐶}
Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 21,22, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 116,117,118, Chrome 114,115,116,117,118, Safari 16.6,17.0, Opera 101,102,103, Safari on iOS 16.6,17.0, Android Browser 118, Chrome for Android 118 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features

blocks/subscriptions-block/_index.scss

github-actions · 2023-11-28T20:17:36Z

blocks/subscriptions-block/components/usePaymentOptions.jsx

@@ -0,0 +1,66 @@
+import { useState, useEffect } from "react";


🚫 [stylelint] _{reported by reviewdog 🐶}
Unknown word (CssSyntaxError) CssSyntaxError

blocks/subscriptions-block/components/usePaymentRedirect.jsx

blocks/subscriptions-block/_index.scss

LauraPinilla · 2023-11-29T18:31:34Z

blocks/subscriptions-block/components/usePaymentRedirect.jsx

+
+	useEffect(() => {
+		const initPayment = async () => {
+			const config = await Sales.getConfig();


@edwardcho1231 config is not being used, you can remove this

LauraPinilla · 2023-11-29T18:42:00Z

blocks/subscriptions-block/components/usePaymentRedirect.jsx

+				setError(e);
+			}
+		};
+		if (currentOrder && currentMerchantId) {


You can modify this by
if (currentOrder?.orderNumber && currentMerchantId), and delete if on L37

LauraPinilla · 2023-11-29T19:00:39Z

blocks/subscriptions-block/features/checkout/_children/PaymentInfo/index.jsx

@@ -1,51 +1,174 @@
-import React, { useEffect, useState } from "react";
+import React, { useEffect, useState, useMemo } from "react";


useMemo is unused

LauraPinilla · 2023-11-29T19:06:04Z

blocks/subscriptions-block/features/checkout/_children/PaymentInfo/index.jsx

+	const payWithCardDividerLabel = phrases.t("subscriptions-block.payWithCard-label");
+
+	useEffect(() => {
+		if (stripeIntents?.paymentMethodID && !errorPaymentOption) {


I think here we need to add !isInitialized.
if (stripeIntents?.paymentMethodID && !errorPaymentOption && !isInitialized), in order to avoid to call get and create a new cart, if we are trying to call finalize

LauraPinilla · 2023-11-29T19:17:23Z

blocks/subscriptions-block/features/checkout/default.jsx

 import PropTypes from "@arc-fusion/prop-types";
 import { usePhrases, Heading, Link, useIdentity } from "@wpmedia/arc-themes-components";
-import useSales from "../../components/useSales";
+import usePaymentOptions from "../../components/usePaymentOptions";
 import Cart from "../../components/Cart";
 import ContactInfo from "../../components/ContactInfo";
 import PaymentInfo from "./_children/PaymentInfo";

 const BLOCK_CLASS_NAME = "b-checkout";



Since LABEL_ORDER_NUMBER_PAYPAL it's a constant, maybe define here at the beginig

LauraPinilla · 2023-11-29T20:34:29Z

blocks/subscriptions-block/components/usePaymentRedirect.jsx

+		const finalizePayment = async () => {
+			try {
+				await Sales.finalizePayment(orderNumber, currentMerchantId, token, null);
+				window.location.href = successURL;


I think you can remove the order from localstorage, once this call is done

vgalatro · 2023-11-29T21:14:54Z

locale/en.json

-		"subscriptions-block.payment-information": "Credit card information",
-		"subscriptions-block.submit-payment": "Purchase Subscription"
+		"subscriptions-block.submit-payment": "Purchase Subscription",
+		"subscriptions-block.payWithCard-label": "Or Pay with card"


@edwardcho1231 , when adding a new translation key, we need it added for all languages. The guide for doing so is here: https://arcpublishing.atlassian.net/wiki/spaces/TI/pages/2538275032/Arc+Themes+Blocks+Internationalisation.

@vgalatro I thought you guys put in the lokalise order. Is this not true and we should put in the order for translation and commit the change to this branch?

You don't need to put in the order, just update the data we have in Lokalise so our product owner can make the order later.

Although thinking about this change a bit more, is it really necessary to change the already existing string right now, from subscriptions-block.payment-information to subscriptions-block.payWithCard-label? We have a lot in progress with our RTL work and adding new translation strings at the moment is not ideal.

We don't have access to Lokalise themes project so I cannot upload files into the project. We are not changing an existing string but adding a new one as it's requested by the design.

LauraPinilla · 2023-11-29T22:13:36Z

blocks/subscriptions-block/features/checkout/_children/PaymentInfo/index.jsx

+			<HeadingSection>
+				<Heading>{formLabel}</Heading>
+			</HeadingSection>
+			{paypal && 


Since here, L135 & L144 you are checking paypal exists, maybe you can include all these in a single block, something like
{paypal && ( .... "all you have related to paypal" )}

I think we might need two blocks since we want the divider to show even when isPayPal is false (before the user clicks on the PayPal button)

github-actions · 2023-11-30T20:22:01Z

blocks/subscriptions-block/_index.scss

@@ -50,6 +50,41 @@
 		@include scss.block-components("checkout-payment");


⚠️ [stylelint] _{reported by reviewdog 🐶}
Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 22,23, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 117,118,119, Chrome 114,116,117,118,119, Safari 16.6,17.0,17.1, Opera 102,103,104, Safari on iOS 16.6-16.7,17.0,17.1, Android Browser 119, Chrome for Android 119 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features

github-actions · 2023-11-30T20:22:02Z

blocks/subscriptions-block/_index.scss

@@ -50,6 +50,41 @@
 		@include scss.block-components("checkout-payment");
 		@include scss.block-properties("checkout-payment");


⚠️ [stylelint] _{reported by reviewdog 🐶}
Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 22,23, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 117,118,119, Chrome 114,116,117,118,119, Safari 16.6,17.0,17.1, Opera 102,103,104, Safari on iOS 16.6-16.7,17.0,17.1, Android Browser 119, Chrome for Android 119 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features

github-actions · 2023-11-30T20:22:02Z

blocks/subscriptions-block/_index.scss

@@ -50,6 +50,41 @@
 		@include scss.block-components("checkout-payment");
 		@include scss.block-properties("checkout-payment");

+		&-info {


⚠️ [stylelint] _{reported by reviewdog 🐶}
Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 22,23, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 117,118,119, Chrome 114,116,117,118,119, Safari 16.6,17.0,17.1, Opera 102,103,104, Safari on iOS 16.6-16.7,17.0,17.1, Android Browser 119, Chrome for Android 119 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features

github-actions · 2023-11-30T20:22:02Z

blocks/subscriptions-block/_index.scss

@@ -50,6 +50,41 @@
 		@include scss.block-components("checkout-payment");
 		@include scss.block-properties("checkout-payment");

+		&-info {
+			@include scss.block-components("checkout-payment-info");


⚠️ [stylelint] _{reported by reviewdog 🐶}
Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 22,23, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 117,118,119, Chrome 114,116,117,118,119, Safari 16.6,17.0,17.1, Opera 102,103,104, Safari on iOS 16.6-16.7,17.0,17.1, Android Browser 119, Chrome for Android 119 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features

github-actions · 2023-11-30T20:22:02Z

blocks/subscriptions-block/_index.scss

@@ -50,6 +50,41 @@
 		@include scss.block-components("checkout-payment");
 		@include scss.block-properties("checkout-payment");

+		&-info {
+			@include scss.block-components("checkout-payment-info");
+			@include scss.block-properties("checkout-payment-info");


⚠️ [stylelint] _{reported by reviewdog 🐶}
Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 22,23, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 117,118,119, Chrome 114,116,117,118,119, Safari 16.6,17.0,17.1, Opera 102,103,104, Safari on iOS 16.6-16.7,17.0,17.1, Android Browser 119, Chrome for Android 119 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features

github-actions · 2023-11-30T20:22:03Z

blocks/subscriptions-block/_index.scss

+			}
+
+			&-divider-line {
+				@include scss.block-components("checkout-payment-info-divider-line");


⚠️ [stylelint] _{reported by reviewdog 🐶}
Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 22,23, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 117,118,119, Chrome 114,116,117,118,119, Safari 16.6,17.0,17.1, Opera 102,103,104, Safari on iOS 16.6-16.7,17.0,17.1, Android Browser 119, Chrome for Android 119 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features

github-actions · 2023-11-30T20:22:03Z

blocks/subscriptions-block/_index.scss

+
+			&-divider-line {
+				@include scss.block-components("checkout-payment-info-divider-line");
+				@include scss.block-properties("checkout-payment-info-divider-line");


⚠️ [stylelint] _{reported by reviewdog 🐶}
Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 22,23, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 117,118,119, Chrome 114,116,117,118,119, Safari 16.6,17.0,17.1, Opera 102,103,104, Safari on iOS 16.6-16.7,17.0,17.1, Android Browser 119, Chrome for Android 119 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features

github-actions · 2023-11-30T20:22:03Z

blocks/subscriptions-block/_index.scss

+				@include scss.block-properties("checkout-payment-info-divider-line");
+			}
+		}
+
 		&-form {


⚠️ [stylelint] _{reported by reviewdog 🐶}
Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 22,23, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 117,118,119, Chrome 114,116,117,118,119, Safari 16.6,17.0,17.1, Opera 102,103,104, Safari on iOS 16.6-16.7,17.0,17.1, Android Browser 119, Chrome for Android 119 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features

github-actions · 2023-11-30T20:22:03Z

blocks/subscriptions-block/_index.scss

+				@include scss.block-properties("checkout-payment-info-divider-line");
+			}
+		}
+
 		&-form {
 			@include scss.block-components("checkout-payment-form");


⚠️ [stylelint] _{reported by reviewdog 🐶}
Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 22,23, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 117,118,119, Chrome 114,116,117,118,119, Safari 16.6,17.0,17.1, Opera 102,103,104, Safari on iOS 16.6-16.7,17.0,17.1, Android Browser 119, Chrome for Android 119 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features

github-actions · 2023-11-30T20:22:04Z

blocks/subscriptions-block/_index.scss

+				@include scss.block-properties("checkout-payment-info-divider-line");
+			}
+		}
+
 		&-form {
 			@include scss.block-components("checkout-payment-form");
 			@include scss.block-properties("checkout-payment-form");


⚠️ [stylelint] _{reported by reviewdog 🐶}
Unexpected browser feature "css-nesting" is not supported by Firefox 115, Chrome 109, Safari 15.6, Safari on iOS 15.6-15.7,16.1,16.3, Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 22,23, QQ Browser 13.1, KaiOS Browser 2.5,3.0-3.1 and only partially supported by Edge 117,118,119, Chrome 114,116,117,118,119, Safari 16.6,17.0,17.1, Opera 102,103,104, Safari on iOS 16.6-16.7,17.0,17.1, Android Browser 119, Chrome for Android 119 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features

vgalatro

Made a few change suggestions and there's one question I have on a bit of code. Otherwise it looks good. You can ignore the comment I made about fixing the translation string and blank line, looks like it was fixed while I was reviewing it.

vgalatro · 2023-11-30T20:29:27Z

blocks/subscriptions-block/components/usePaymentOptions.jsx

+import useSales from "./useSales";
+
+const STRIPE_PAYMENT_METHOD_ID = 18;
+const PAYPAL_METOD_ID = 10;


Suggested change

const PAYPAL_METOD_ID = 10;

const PAYPAL_METHOD_ID = 10;

vgalatro · 2023-11-30T20:29:47Z

blocks/subscriptions-block/components/usePaymentOptions.jsx

+					STRIPE_PAYMENT_METHOD_ID,
+					stripeIntentsDefaultID,
+				);
+				const paypal = getPaymentMethodByID(options, PAYPAL_METOD_ID, paypalDefaultID);


Suggested change

const paypal = getPaymentMethodByID(options, PAYPAL_METOD_ID, paypalDefaultID);

const paypal = getPaymentMethodByID(options, PAYPAL_METHOD_ID, paypalDefaultID);

vgalatro · 2023-11-30T20:34:07Z

blocks/subscriptions-block/features/checkout/_children/PaymentInfo/index.jsx

+						const items = currentOrder.items.map((item) => {
+							const { sku, priceCode, quantity } = item;
+							return { sku, priceCode, quantity };
+						});


Is this being done just to filter out the other properties that can be on item?

Yes, this is being done to filter out keys that are not needed.

locale/en.json

vgalatro

LGTM!

…-block

Issue spotted

vgalatro · 2023-12-01T18:09:52Z

@edwardcho1231 , after merging in the latest from 2.1.2 I noticed an issue. Could you add unit test files for the new components you've added? The coverage threshold is pretty low right now as we're still working on fixing our tests for the new node version, so some basic unit tests should be enough for now.

vgalatro

@edwardcho1231 , I can pass this for now, but could you and @mattkim93 make sure that these new changes to subs have proper test coverage. We've lowered requirements temporarily so things could pass, but it seems that there are still issues with the tests in the subs blocks.

* THEMES-1520: Enable testing (and linting THEMES-1460) (#1809) * THEMES-1520: Enable testing (and linting THEMES-1460) * Re-enable test on github action * try to get stylelint to ignore jsx * Attempt #2 to get stylelint to ignore jsx * ASUB-7844 PayPal block (#1806) * move stripe logic into a button * add paypal logic * clean up and try adding styles * clean up logic and create hooks * update styles for paypal * address feedback * add more strings for intl * address feedback * address feedback * add test for PayPal block --------- Co-authored-by: Vito Galatro <[email protected]> * ASUB-7844 Fix issue where identity is not defined in paymentInfo (#1831) fix issue where identity is not defined in paymentInfo * Fix paywall Issue (#1824) * fixing ArcP.run * attending feedback * attending feedback * attending feedback * attending feedback * attending feedback * ASUB-8002 Update payment method (#1813) * changes * payments * remove env file * update payment method - stripe Intents * update payment method * fixing typo * solving conflict --------- Co-authored-by: Vito Galatro <[email protected]> * ASUB-7844 Bug fix (#1836) fix issue with redirect when user is not logged in and adjust setTimeout delay * THEMES-1589: Subs phrases added for all locales (#1837) THEMES-1589: properly added new subs phrases. * Improvement update payment method - missing message (#1839) improvement update payment method- missing message * THEMES-1600: fixed more merge conflicts. * THEMES-1600: yet more merge conflicts. --------- Co-authored-by: nschubach <[email protected]> Co-authored-by: edwardcho1231 <[email protected]> Co-authored-by: LauraPinilla <[email protected]>

move stripe logic into a button

c911ef7

edwardcho1231 requested a review from a team as a code owner November 22, 2023 15:52

edwardcho1231 changed the title ~~ASUB-7844 PayPal block~~ ASUB-7844 PayPal block WIP Nov 22, 2023

github-actions bot reviewed Nov 22, 2023

View reviewed changes

add paypal logic

ae5920e

github-actions bot reviewed Nov 27, 2023

View reviewed changes

github-advanced-security bot found potential problems Nov 27, 2023

View reviewed changes

blocks/subscriptions-block/components/usePaymentRedirect.jsx Fixed Show fixed Hide fixed

edwardcho1231 added 2 commits November 27, 2023 14:44

clean up and try adding styles

354d6ea

clean up logic and create hooks

7427a76

github-actions bot reviewed Nov 28, 2023

View reviewed changes

update styles for paypal

e410f31

github-actions bot reviewed Nov 29, 2023

View reviewed changes

edwardcho1231 changed the title ~~ASUB-7844 PayPal block WIP~~ ASUB-7844 PayPal block Nov 29, 2023

edwardcho1231 added the ready for review The PR author has completed the PR template and is ready for a review label Nov 29, 2023

edwardcho1231 requested review from vgalatro and LauraPinilla November 29, 2023 17:02

LauraPinilla reviewed Nov 29, 2023

View reviewed changes

address feedback

be76d8a

vgalatro reviewed Nov 29, 2023

View reviewed changes

LauraPinilla reviewed Nov 29, 2023

View reviewed changes

edwardcho1231 added 2 commits November 30, 2023 12:02

add more strings for intl

6f38d2d

address feedback

7e91bf4

edwardcho1231 requested a review from vgalatro November 30, 2023 20:22

github-actions bot reviewed Nov 30, 2023

View reviewed changes

edwardcho1231 requested a review from LauraPinilla November 30, 2023 20:22

vgalatro suggested changes Nov 30, 2023

View reviewed changes

vgalatro added needs changes The reviewer has requested changes from the PR author and removed ready for review The PR author has completed the PR template and is ready for a review labels Nov 30, 2023

address feedback

cad4d3e

edwardcho1231 added ready for review The PR author has completed the PR template and is ready for a review and removed needs changes The reviewer has requested changes from the PR author labels Dec 1, 2023

vgalatro previously approved these changes Dec 1, 2023

View reviewed changes

Merge branch 'arc-themes-release-version-2.1.2' into ASUB-7844/paypal…

d69b353

…-block

vgalatro added needs changes The reviewer has requested changes from the PR author and removed ready for review The PR author has completed the PR template and is ready for a review labels Dec 1, 2023

add test for PayPal block

c270691

edwardcho1231 requested a review from vgalatro December 4, 2023 16:27

edwardcho1231 added ready for review The PR author has completed the PR template and is ready for a review and removed needs changes The reviewer has requested changes from the PR author labels Dec 4, 2023

vgalatro approved these changes Dec 4, 2023

View reviewed changes

vgalatro merged commit 11af306 into arc-themes-release-version-2.1.2 Dec 4, 2023
3 of 6 checks passed

vgalatro deleted the ASUB-7844/paypal-block branch December 4, 2023 18:17

		@@ -1,17 +1,22 @@
		import React, { useEffect, useState } from "react";
		import React, { useEffect, useState, useMemo } from "react";

		@@ -0,0 +1,105 @@
		import { useState, useEffect } from 'react';

		@@ -1,4 +1,4 @@
		import React, { useEffect, useState } from "react";
		import React, { useEffect, useState, useMemo } from "react";

		@@ -0,0 +1,66 @@
		import { useState, useEffect } from "react";

		@@ -1,51 +1,174 @@
		import React, { useEffect, useState } from "react";
		import React, { useEffect, useState, useMemo } from "react";

		@@ -50,6 +50,41 @@
		@include scss.block-components("checkout-payment");

		@@ -50,6 +50,41 @@
		@include scss.block-components("checkout-payment");
		@include scss.block-properties("checkout-payment");

	const paypal = getPaymentMethodByID(options, PAYPAL_METOD_ID, paypalDefaultID);
	const paypal = getPaymentMethodByID(options, PAYPAL_METHOD_ID, paypalDefaultID);

ASUB-7844 PayPal block #1806

ASUB-7844 PayPal block #1806

Conversation

edwardcho1231 commented Nov 22, 2023

Description

Jira Ticket

Acceptance Criteria

Test Steps

Effect Of Changes

Before

After

Dependencies or Side Effects

Author Checklist

Reviewer Checklist

github-actions bot Nov 22, 2023

Choose a reason for hiding this comment

github-actions bot Nov 27, 2023

Choose a reason for hiding this comment

github-actions bot Nov 27, 2023

Choose a reason for hiding this comment

github-actions bot Nov 28, 2023

Choose a reason for hiding this comment

github-actions bot Nov 28, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

LauraPinilla Nov 29, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

edwardcho1231 Nov 30, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot Nov 30, 2023

Choose a reason for hiding this comment

github-actions bot Nov 30, 2023

Choose a reason for hiding this comment

github-actions bot Nov 30, 2023

Choose a reason for hiding this comment

github-actions bot Nov 30, 2023

Choose a reason for hiding this comment

github-actions bot Nov 30, 2023

Choose a reason for hiding this comment

github-actions bot Nov 30, 2023

Choose a reason for hiding this comment

github-actions bot Nov 30, 2023

Choose a reason for hiding this comment

github-actions bot Nov 30, 2023

Choose a reason for hiding this comment

github-actions bot Nov 30, 2023

Choose a reason for hiding this comment

github-actions bot Nov 30, 2023

Choose a reason for hiding this comment

vgalatro left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vgalatro left a comment

Choose a reason for hiding this comment

vgalatro commented Dec 1, 2023

vgalatro left a comment

Choose a reason for hiding this comment

LauraPinilla Nov 29, 2023 •

edited

Loading

edwardcho1231 Nov 30, 2023 •

edited

Loading