Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

THEMES-1218: Logical Properties on Misc Blocks #1826

Merged
merged 2 commits into from
Dec 4, 2023

Conversation

vgalatro
Copy link
Contributor

@vgalatro vgalatro commented Dec 1, 2023

Description

This PR updates the styling for the Alert bar block, the only one from the ticket that needed updates.

Jira Ticket

Acceptance Criteria

  1. The above logical properties are applied and tested on the above components/blocks.
  2. Storybook is updated with RTL.

Test Steps

  1. Checkout this branch git checkout THEMES-1218
  2. Run fusion repo with linked blocks npx fusion start -f -l @wpmedia/alert-bar-block
  3. Inspect the alert bar and see that it is using logical properties in the correct places.
  4. It should match the designs in Figma.
  5. Set "textDirection": "rtl" in the "siteProperties" object of the blocks.json.
  6. Restart PageBuilder and verify that the styling adapts to the new text direction.

Author Checklist

  • Confirmed all the test steps a reviewer will follow above are working.
  • Confirmed there are no linter errors. Please run npm run lint to check for errors. Often, npm run lint:fix will fix those errors and warnings.
  • Ran this code locally and checked that there are not any unintended side effects. For example, that a CSS selector is scoped only to a particular block.
  • Confirmed this PR has reasonable code coverage. You can run npm run test:coverage to see your progress.
    • Confirmed this PR has unit test files
    • Ran npm run test, made sure all tests are passing
    • If the amount of work to write unit tests for this change are excessive,
      please explain why (so that we can fix it whenever it gets refactored).
  • Confirmed relevant documentation has been updated/added.

Reviewer Checklist

The reviewer of the PR should copy-paste this template into the review comments on review.

  • Linting code actions have passed.
  • Ran the code locally based on the test instructions.
    • I don’t think this is needed to be tested locally. For example, a padding style change (storybook?) or a logic change (write a test).
  • I am a member of the engine theme team so that I can approve and merge this. If you're not on the team, you won't have access to approve and merge this pr.
  • Looked to see that the new or changed code has code coverage, specifically. We want the global code coverage to keep on going up with targeted testing.

@vgalatro vgalatro added the ready for review The PR author has completed the PR template and is ready for a review label Dec 1, 2023
@vgalatro vgalatro requested a review from a team as a code owner December 1, 2023 19:20
@@ -201,10 +201,7 @@
"inline-size": 100%,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may need to be updated again once #1823 is merged in. I expect their may be some conflicts.

@blakeganderson blakeganderson self-assigned this Dec 4, 2023
@blakeganderson blakeganderson added the review in progress A review is underway. Even if an approval has been submitted, wait for all reviews to be completed. label Dec 4, 2023
Copy link
Contributor

@blakeganderson blakeganderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@blakeganderson blakeganderson added ready to merge It's time! Merge this PR. Woo! and removed review in progress A review is underway. Even if an approval has been submitted, wait for all reviews to be completed. labels Dec 4, 2023
@vgalatro vgalatro merged commit f7d0b65 into arc-themes-release-version-2.1.3 Dec 4, 2023
5 of 6 checks passed
@vgalatro vgalatro deleted the THEMES-1218 branch December 4, 2023 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review The PR author has completed the PR template and is ready for a review ready to merge It's time! Merge this PR. Woo!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants