Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASUB-7844 Bug fix #1836

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Conversation

edwardcho1231
Copy link
Contributor

@edwardcho1231 edwardcho1231 commented Dec 6, 2023

If you have not filled out the checklist below, the pr is not ready for review.

Description

  • fix setTimeout delay in usePaywall hook
  • fix redirect url variables not defined in PaymentInfo

Jira Ticket

Acceptance Criteria

copy from ticket

Test Steps

  • Add test steps a reviewer must complete to test this PR
  1. Checkout this branch git checkout {branch name}
  2. Run fusion repo with linked blocks npx fusion start -f -l {blocks to link}
  3. {Next ....}

Effect Of Changes

Before

Example: When I clicked the search button, the button turned red.

[include screenshot or gif or link to video, storybook would be awesome]

After

Example: When I clicked the search button, the button turned green.

[include screenshot or gif or link to video, storybook would be awesome]

Dependencies or Side Effects

Examples of dependencies or side effects are:

Author Checklist

The author of the PR should fill out the following sections to ensure this PR is ready for review.

  • Confirmed all the test steps a reviewer will follow above are working.
  • Confirmed there are no linter errors. Please run npm run lint to check for errors. Often, npm run lint:fix will fix those errors and warnings.
  • Ran this code locally and checked that there are not any unintended side effects. For example, that a CSS selector is scoped only to a particular block.
  • Confirmed this PR has reasonable code coverage. You can run npm run test:coverage to see your progress.
    • Confirmed this PR has unit test files
    • Ran npm run test, made sure all tests are passing
    • If the amount of work to write unit tests for this change are excessive,
      please explain why (so that we can fix it whenever it gets refactored).
  • Confirmed relevant documentation has been updated/added.

Reviewer Checklist

The reviewer of the PR should copy-paste this template into the review comments on review.

  • Linting code actions have passed.
  • Ran the code locally based on the test instructions.
    • I don’t think this is needed to be tested locally. For example, a padding style change (storybook?) or a logic change (write a test).
  • I am a member of the engine theme team so that I can approve and merge this. If you're not on the team, you won't have access to approve and merge this pr.
  • Looked to see that the new or changed code has code coverage, specifically. We want the global code coverage to keep on going up with targeted testing.

@edwardcho1231 edwardcho1231 requested a review from a team as a code owner December 6, 2023 20:12
@edwardcho1231 edwardcho1231 added the ready for review The PR author has completed the PR template and is ready for a review label Dec 6, 2023
Copy link
Contributor

@vgalatro vgalatro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vgalatro vgalatro merged commit c5e8bf7 into arc-themes-release-version-2.1.2 Dec 7, 2023
4 of 6 checks passed
@vgalatro vgalatro deleted the ASUB-7844/paypal-fix2 branch December 7, 2023 15:07
rmbrntt pushed a commit that referenced this pull request Dec 21, 2023
* THEMES-1520: Enable testing (and linting THEMES-1460) (#1809)

* THEMES-1520: Enable testing (and linting THEMES-1460)

* Re-enable test on github action

* try to get stylelint to ignore jsx

* Attempt #2 to get stylelint to ignore jsx

* ASUB-7844 PayPal block (#1806)

* move stripe logic into a button

* add paypal logic

* clean up and try adding styles

* clean up logic and create hooks

* update styles for paypal

* address feedback

* add more strings for intl

* address feedback

* address feedback

* add test for PayPal block

---------

Co-authored-by: Vito Galatro <[email protected]>

* ASUB-7844 Fix issue where identity is not defined in paymentInfo (#1831)

fix issue where identity is not defined in paymentInfo

* Fix paywall Issue (#1824)

* fixing ArcP.run

* attending feedback

* attending feedback

* attending feedback

* attending feedback

* attending feedback

* ASUB-8002 Update payment method (#1813)

* changes

* payments

* remove env file

* update payment method - stripe Intents

* update payment method

* fixing typo

* solving conflict

---------

Co-authored-by: Vito Galatro <[email protected]>

* ASUB-7844 Bug fix (#1836)

fix issue with redirect when user is not logged in and adjust setTimeout delay

* THEMES-1589: Subs phrases added for all locales (#1837)

THEMES-1589: properly added new subs phrases.

* Improvement update payment method - missing message (#1839)

improvement update payment method- missing message

* THEMES-1600: fixed more merge conflicts.

* THEMES-1600: yet more merge conflicts.

---------

Co-authored-by: nschubach <[email protected]>
Co-authored-by: edwardcho1231 <[email protected]>
Co-authored-by: LauraPinilla <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review The PR author has completed the PR template and is ready for a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants