Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

THEMES-1654: Card List block not respecting time format #1919

Merged
merged 4 commits into from
Jan 23, 2024

Conversation

vgalatro
Copy link
Contributor

@vgalatro vgalatro commented Jan 22, 2024

Description

This PR fixes a bug where the card list block would always use the default time format.

Jira Ticket

Acceptance Criteria

The card list block uses the site's time format when it is set

Test Steps

  1. Checkout this branch git checkout THEMES-1654
  2. In your local blocks.json change the dateTimeFormat property to something noticeably different than the default (such as using %b instead of %B so the short month name appears, or adding %A to show the day of the week).
  3. Run fusion repo with linked blocks npx fusion start -f -l @wpmedia/card-list-block
  4. Add a Card list - Arc block to a page with a query of type: story and showing a few items.
  5. The top most item should show the date and time in the format specified in the blocks.json.

Author Checklist

  • Confirmed all the test steps a reviewer will follow above are working.
  • Confirmed there are no linter errors. Please run npm run lint to check for errors. Often, npm run lint:fix will fix those errors and warnings.
  • Ran this code locally and checked that there are not any unintended side effects. For example, that a CSS selector is scoped only to a particular block.
  • Confirmed this PR has reasonable code coverage. You can run npm run test:coverage to see your progress.
    • Confirmed this PR has unit test files
    • Ran npm run test, made sure all tests are passing
    • If the amount of work to write unit tests for this change are excessive,
      please explain why (so that we can fix it whenever it gets refactored).
  • Confirmed relevant documentation has been updated/added.

Reviewer Checklist

The reviewer of the PR should copy-paste this template into the review comments on review.

  • Linting code actions have passed.
  • Ran the code locally based on the test instructions.
    • I don’t think this is needed to be tested locally. For example, a padding style change (storybook?) or a logic change (write a test).
  • I am a member of the engine theme team so that I can approve and merge this. If you're not on the team, you won't have access to approve and merge this pr.
  • Looked to see that the new or changed code has code coverage, specifically. We want the global code coverage to keep on going up with targeted testing.

@vgalatro vgalatro requested a review from a team as a code owner January 22, 2024 18:42
@vgalatro vgalatro added the ready for review The PR author has completed the PR template and is ready for a review label Jan 22, 2024
@vgalatro vgalatro merged commit 755fd6e into arc-themes-release-version-2.1.4 Jan 23, 2024
4 of 5 checks passed
@vgalatro vgalatro deleted the THEMES-1654 branch January 23, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review The PR author has completed the PR template and is ready for a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants