THEMES-1654: Card List block not respecting time format #1919
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug where the card list block would always use the default time format.
Jira Ticket
Acceptance Criteria
The card list block uses the site's time format when it is set
Test Steps
git checkout THEMES-1654
blocks.json
change thedateTimeFormat
property to something noticeably different than the default (such as using%b
instead of%B
so the short month name appears, or adding%A
to show the day of the week).npx fusion start -f -l @wpmedia/card-list-block
type: story
and showing a few items.blocks.json
.Author Checklist
npm run lint
to check for errors. Often,npm run lint:fix
will fix those errors and warnings.npm run test:coverage
to see your progress.npm run test
, made sure all tests are passingplease explain why (so that we can fix it whenever it gets refactored).
Reviewer Checklist
The reviewer of the PR should copy-paste this template into the review comments on review.