Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added divider between main section and right rail for both right-rail and right-rail-advanced layouts.
NOTE: I did not use the divider component because I would have to wrap the right rail in an additional div with display:flex in order to get the divider component to render vertically. The approach I used is the same approach we use in the footer top container
Jira Ticket
Acceptance Criteria
A vertical divider should be displayed between the right rail and the main section, this applies for
Test Steps
git checkout THEMES-1641
npx fusion start -f -l @wpmedia/right-rail-advanced-block,@wpmedia/right-rail-block
Effect Of Changes
Before
No divider between main and right rail sections
After
Divider between main and right rail sections
Dependencies or Side Effects
Examples of dependencies or side effects are:
Author Checklist
The author of the PR should fill out the following sections to ensure this PR is ready for review.
npm run lint
to check for errors. Often,npm run lint:fix
will fix those errors and warnings.npm run test:coverage
to see your progress.npm run test
, made sure all tests are passingplease explain why (so that we can fix it whenever it gets refactored).
Reviewer Checklist
The reviewer of the PR should copy-paste this template into the review comments on review.