THEMES-891: Non-manual images focal point support#1966
Merged
vgalatro merged 9 commits intoarc-themes-release-version-2.3.0from Mar 20, 2024
Merged
THEMES-891: Non-manual images focal point support#1966vgalatro merged 9 commits intoarc-themes-release-version-2.3.0from
vgalatro merged 9 commits intoarc-themes-release-version-2.3.0from
Conversation
…h results list block.
Contributor
Author
|
Marking as do not merge since we want this in the next release, not 2.2.0. |
Contributor
Author
|
@blakeganderson , I'll need a re-review here too. Fixed a couple of merge conflicts with 2.3.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates multiple blocks with the new
getFocalFromANShelper function so that they can properly send focal point info to theImagecomponent. The original ticket mentions the gallery block, but gallery images are displayed at their full aspect ratio with no cropping, so the focal point will not matter.Jira Ticket
Acceptance Criteria
Test Steps
git checkout THEMES-891arc-themes-release-version-2.2.0branch is checked out.npx fusion start -f -l @wpmedia/card-list-block,@wpmedia/extra-large-promo-block,@wpmedia/large-promo-block,@wpmedia/lead-art-block,@wpmedia/medium-promo-block,@wpmedia/numbered-list-block,@wpmedia/product-assortment-carousel-block,@wpmedia/product-featured-image-block,@wpmedia/results-list-block,@wpmedia/search-results-list-block,@wpmedia/simple-list-block,@wpmedia/small-promo-block,@wpmedia/top-table-list-block/global/2024/02/23/story-with-focal-point-promo-pyramid//travel/2024/02/16/story-with-focal-point-images/Author Checklist
npm run lintto check for errors. Often,npm run lint:fixwill fix those errors and warnings.npm run test:coverageto see your progress.npm run test, made sure all tests are passingplease explain why (so that we can fix it whenever it gets refactored).
Reviewer Checklist
The reviewer of the PR should copy-paste this template into the review comments on review.