-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
THEMES-891: Non-manual images focal point support #1966
Conversation
…h results list block.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Marking as do not merge since we want this in the next release, not 2.2.0. |
@blakeganderson , I'll need a re-review here too. Fixed a couple of merge conflicts with 2.3.0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fd14ee5
into
arc-themes-release-version-2.3.0
Description
This PR updates multiple blocks with the new
getFocalFromANS
helper function so that they can properly send focal point info to theImage
component. The original ticket mentions the gallery block, but gallery images are displayed at their full aspect ratio with no cropping, so the focal point will not matter.Jira Ticket
Acceptance Criteria
Test Steps
git checkout THEMES-891
arc-themes-release-version-2.2.0
branch is checked out.npx fusion start -f -l @wpmedia/card-list-block,@wpmedia/extra-large-promo-block,@wpmedia/large-promo-block,@wpmedia/lead-art-block,@wpmedia/medium-promo-block,@wpmedia/numbered-list-block,@wpmedia/product-assortment-carousel-block,@wpmedia/product-featured-image-block,@wpmedia/results-list-block,@wpmedia/search-results-list-block,@wpmedia/simple-list-block,@wpmedia/small-promo-block,@wpmedia/top-table-list-block
/global/2024/02/23/story-with-focal-point-promo-pyramid/
/travel/2024/02/16/story-with-focal-point-images/
Author Checklist
npm run lint
to check for errors. Often,npm run lint:fix
will fix those errors and warnings.npm run test:coverage
to see your progress.npm run test
, made sure all tests are passingplease explain why (so that we can fix it whenever it gets refactored).
Reviewer Checklist
The reviewer of the PR should copy-paste this template into the review comments on review.