Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed margin logical properties #1967

Merged

Conversation

malavikakoppula
Copy link
Contributor

@malavikakoppula malavikakoppula commented Feb 26, 2024

Description

convert margin into logical property

Jira Ticket

Test Steps

  1. Checkout this branch git checkout THEMES-1731-margin-fix
  2. Run fusion repo with linked blocks npx fusion start -f -l @wpmedia/medium-promo-block

Dependencies or Side Effects

Author Checklist

The author of the PR should fill out the following sections to ensure this PR is ready for review.

  • Confirmed all the test steps a reviewer will follow above are working.
  • Confirmed there are no linter errors. Please run npm run lint to check for errors. Often, npm run lint:fix will fix those errors and warnings.
  • Ran this code locally and checked that there are not any unintended side effects. For example, that a CSS selector is scoped only to a particular block.
  • Confirmed this PR has reasonable code coverage. You can run npm run test:coverage to see your progress.
    • Confirmed this PR has unit test files
    • Ran npm run test, made sure all tests are passing
    • If the amount of work to write unit tests for this change are excessive,
      please explain why (so that we can fix it whenever it gets refactored).
  • Confirmed relevant documentation has been updated/added.

Reviewer Checklist

The reviewer of the PR should copy-paste this template into the review comments on review.

  • Linting code actions have passed.
  • Ran the code locally based on the test instructions.
    • I don’t think this is needed to be tested locally. For example, a padding style change (storybook?) or a logic change (write a test).
  • I am a member of the engine theme team so that I can approve and merge this. If you're not on the team, you won't have access to approve and merge this pr.
  • Looked to see that the new or changed code has code coverage, specifically. We want the global code coverage to keep on going up with targeted testing.

@malavikakoppula malavikakoppula requested a review from a team as a code owner February 26, 2024 16:00
@malavikakoppula malavikakoppula added the ready for review The PR author has completed the PR template and is ready for a review label Feb 26, 2024
Copy link
Contributor

@vgalatro vgalatro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small change needed, to keep the storybook SCSS in line with the JSON files.

.storybook/themes/news.scss Outdated Show resolved Hide resolved
.storybook/themes/commerce.scss Outdated Show resolved Hide resolved
@vgalatro vgalatro added needs changes The reviewer has requested changes from the PR author and removed ready for review The PR author has completed the PR template and is ready for a review labels Feb 26, 2024
@malavikakoppula malavikakoppula added additional review The PR author has requested multiple reviewers. Do not merge until at least 2 approvals are complete and removed needs changes The reviewer has requested changes from the PR author labels Feb 26, 2024
Copy link
Contributor

@vgalatro vgalatro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vgalatro vgalatro added ready to merge It's time! Merge this PR. Woo! and removed additional review The PR author has requested multiple reviewers. Do not merge until at least 2 approvals are complete labels Feb 27, 2024
@malavikakoppula malavikakoppula merged commit 968a082 into arc-themes-release-version-2.2.0 Feb 27, 2024
3 of 5 checks passed
@malavikakoppula malavikakoppula deleted the THEMES-1731-margin-fix branch February 27, 2024 14:42
@malavikakoppula malavikakoppula removed the ready to merge It's time! Merge this PR. Woo! label Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants