-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Themes-1204] Added color to full-author-bio and short-author-bio headings #1970
Merged
malavikakoppula
merged 5 commits into
arc-themes-release-version-2.2.1
from
THEMES-1204
Mar 11, 2024
Merged
[Themes-1204] Added color to full-author-bio and short-author-bio headings #1970
malavikakoppula
merged 5 commits into
arc-themes-release-version-2.2.1
from
THEMES-1204
Mar 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blakeganderson
previously approved these changes
Feb 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Marking as |
The base branch was changed.
This is releasing as part of 2.2.1 |
vgalatro
approved these changes
Mar 11, 2024
d809447
into
arc-themes-release-version-2.2.1
2 of 4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Full bio block role connect text needs to be updated to be a text-color alias token. So the color of the font doesn’t change.
Jira Ticket
Acceptance Criteria
Test Steps
git checkout THEMES-1204
npx fusion start -f -l @wpmedia/author-bio-block,@wpmedia/full-author-bio-block
Effect Of Changes
Before
After
Dependencies or Side Effects
Author Checklist
The author of the PR should fill out the following sections to ensure this PR is ready for review.
npm run lint
to check for errors. Often,npm run lint:fix
will fix those errors and warnings.npm run test:coverage
to see your progress.npm run test
, made sure all tests are passingplease explain why (so that we can fix it whenever it gets refactored).
Reviewer Checklist
The reviewer of the PR should copy-paste this template into the review comments on review.