Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Themes-1204] Added color to full-author-bio and short-author-bio headings #1970

Merged
merged 5 commits into from
Mar 11, 2024

Conversation

malavikakoppula
Copy link
Contributor

@malavikakoppula malavikakoppula commented Feb 27, 2024

Description

The Full bio block role connect text needs to be updated to be a text-color alias token. So the color of the font doesn’t change.

Jira Ticket

Acceptance Criteria

  • Update the font color of the author role and the connect text as the text-color in the Full author bio block.
  • Update the font of the author’s name in the short bio block to be the primary color.

Test Steps

  1. Checkout this branch git checkout THEMES-1204
  2. Run fusion repo with linked blocks npx fusion start -f -l @wpmedia/author-bio-block,@wpmedia/full-author-bio-block
  3. Add content api _id: 7E3ZKVJFVJBNBAWIKNENACWWTA
  4. inspect for short-author-bio author name to be color-primary and, full-author-bio role and social-header to be text-color alias token

Effect Of Changes

Before

Screenshot 2024-02-27 at 4 07 32 PM Screenshot 2024-02-27 at 4 08 21 PM

After

Screenshot 2024-02-27 at 4 05 54 PM

Dependencies or Side Effects

Author Checklist

The author of the PR should fill out the following sections to ensure this PR is ready for review.

  • Confirmed all the test steps a reviewer will follow above are working.
  • Confirmed there are no linter errors. Please run npm run lint to check for errors. Often, npm run lint:fix will fix those errors and warnings.
  • Ran this code locally and checked that there are not any unintended side effects. For example, that a CSS selector is scoped only to a particular block.
  • Confirmed this PR has reasonable code coverage. You can run npm run test:coverage to see your progress.
    • Confirmed this PR has unit test files
    • Ran npm run test, made sure all tests are passing
    • If the amount of work to write unit tests for this change are excessive,
      please explain why (so that we can fix it whenever it gets refactored).
  • Confirmed relevant documentation has been updated/added.

Reviewer Checklist

The reviewer of the PR should copy-paste this template into the review comments on review.

  • Linting code actions have passed.
  • Ran the code locally based on the test instructions.
    • I don’t think this is needed to be tested locally. For example, a padding style change (storybook?) or a logic change (write a test).
  • I am a member of the engine theme team so that I can approve and merge this. If you're not on the team, you won't have access to approve and merge this pr.
  • Looked to see that the new or changed code has code coverage, specifically. We want the global code coverage to keep on going up with targeted testing.

@malavikakoppula malavikakoppula requested a review from a team as a code owner February 27, 2024 21:15
@malavikakoppula malavikakoppula added the ready for review The PR author has completed the PR template and is ready for a review label Feb 27, 2024
@malavikakoppula malavikakoppula changed the title Themes 1204 [Themes-1204] Added color to full-author-bio and short-author-bio headings Feb 27, 2024
@malavikakoppula malavikakoppula added the do not merge Do not merge, wait to merge this ticket until this label is removed. label Feb 28, 2024
blakeganderson
blakeganderson previously approved these changes Feb 28, 2024
Copy link
Contributor

@blakeganderson blakeganderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@malavikakoppula malavikakoppula removed the ready for review The PR author has completed the PR template and is ready for a review label Feb 28, 2024
@malavikakoppula
Copy link
Contributor Author

Marking as do not merge since we want this in the next release, not 2.2.0.

@malavikakoppula malavikakoppula changed the base branch from arc-themes-release-version-2.2.0 to arc-themes-release-version-2.2.1 March 7, 2024 17:31
@malavikakoppula malavikakoppula dismissed blakeganderson’s stale review March 7, 2024 17:31

The base branch was changed.

@malavikakoppula malavikakoppula added additional review The PR author has requested multiple reviewers. Do not merge until at least 2 approvals are complete and removed do not merge Do not merge, wait to merge this ticket until this label is removed. labels Mar 7, 2024
@malavikakoppula
Copy link
Contributor Author

Marking as do not merge since we want this in the next release, not 2.2.0.

This is releasing as part of 2.2.1

@vgalatro vgalatro added ready to merge It's time! Merge this PR. Woo! and removed additional review The PR author has requested multiple reviewers. Do not merge until at least 2 approvals are complete labels Mar 11, 2024
@malavikakoppula malavikakoppula merged commit d809447 into arc-themes-release-version-2.2.1 Mar 11, 2024
2 of 4 checks passed
@malavikakoppula malavikakoppula deleted the THEMES-1204 branch March 11, 2024 14:49
@malavikakoppula malavikakoppula removed the ready to merge It's time! Merge this PR. Woo! label Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants