add fix for redirect

[accbjt]

If you have not filled out the checklist below, the pr is not ready for review.

Description

• This is a fix for the log in redirect. When logged in the user would not get redirected back to the page they were on.
• This also has a fix for the RegWall button getting blocked in mobile.

Jira Ticket

• ASUB-8279
• ASUB-8199

Acceptance Criteria

• Should redirect to the previous page after logging in.
• Registration Wall should be above the fold on Safari and Chrome

Test Steps

Log in Redirect:

• Sign up and make sure you have an account with the website. Create a sign up page if needed
• Create a page for the login page to redirect to with a link to the log in page that you can click on.
• Create a log in page if you do not have one.
• Open the page for the redirect page.
• Click on the log in link - this will redirect you to the log in page.
• Fill out the form to log in.
• Log in should redirect you to the redirect page you created.

RegWall button:

• Create a page with the Paywall block
• Add the RegWall
• You will need to comment some code and return only the RegWall in the paywall theme block. This will allow you to see the RegWall without any logic to trigger a showing of the RegWall.

	return (
		<RegwallOffer
			actionText={registerActionText}
			actionUrl={registerActionUrl}
			displayMode={displayMode}
			headlineText={registerHeaderText}
			linkPrompt={payLinkPrompt}
			linkText={linkText}
			linkUrl={linkUrl}
			reasonPrompt={registerReasonPrompt}
			subheadlineText={registerSubHeaderText}
			className={BLOCK_CLASS_NAME}
		/>
	);

• You will need to either open the Paywall page on a iPhone device using the IP address or you can open it in the Xcode simulator. You can only test Chrome on a mobile device.

Effect Of Changes

Before

Login Redirect:

• Click log in from an article.
• Log in - then it would send you to the home page and not the article you were on.

RegWall:

After

Login Redirect:

• Should redirect you to the article page you were on after you log in.

RegWall:

Dependencies or Side Effects

None

• Manifest pr for new block:
• Feature pack pr for local development:
• How to deploy to news: https://arcpublishing.atlassian.net/wiki/spaces/TI/pages/3138682964/News+Theme+2.0+Migration+Development+Deployment+Notes
• Additional settings that will be required in the blocks.json
• Changes to the custom fields which will require users to reconfigure features
• Dependency on another PR that needs to be merged first

Author Checklist

The author of the PR should fill out the following sections to ensure this PR is ready for review.

• Confirmed all the test steps a reviewer will follow above are working.
• Confirmed there are no linter errors. Please run npm run lint to check for errors. Often, npm run lint:fix will fix those errors and warnings.
• Ran this code locally and checked that there are not any unintended side effects. For example, that a CSS selector is scoped only to a particular block.
• Confirmed this PR has reasonable code coverage. You can run npm run test:coverage to see your progress.
  • Confirmed this PR has unit test files
  • Ran npm run test, made sure all tests are passing
  • If the amount of work to write unit tests for this change are excessive,
    please explain why (so that we can fix it whenever it gets refactored).
• Confirmed relevant documentation has been updated/added.

Reviewer Checklist

The reviewer of the PR should copy-paste this template into the review comments on review.

• Linting code actions have passed.
• Ran the code locally based on the test instructions.
  • I don’t think this is needed to be tested locally. For example, a padding style change (storybook?) or a logic change (write a test).
• I am a member of the engine theme team so that I can approve and merge this. If you're not on the team, you won't have access to approve and merge this pr.
• Looked to see that the new or changed code has code coverage, specifically. We want the global code coverage to keep on going up with targeted testing.

[accbjt]

@vgalatro I made the fixes for the style linting and also fix the test. Looks like the project is missing the storybook module and also the stylelint is failing on a sh issue. When I run it locally it looks fine.

[vgalatro]

Yeah storybook is currently not working. The version we're using won't run on correctly on the newer versions of node and upgrading to the latest version of Storybook is a large lift that we're still looking into.

[vgalatro]

@accbjt , just one question about a configuration change, otherwise everything is looking good.

[vgalatro]

Is there a reason behind this configuration change? I'm not seeing a difference in results with the linter with or without this setting.

[accbjt]

On my computer it was giving me an error and wouldn't lint my files. Not sure why it was doing it but this is what fixed it. When I remove this line of code I get this error.

Parsing error: No Babel config file detected for /Users/tranb2/Sites/wpmedia/arc-themes-blocks/blocks/identity-block/components/login/index.jsx. Either disable config file checking with requireConfigFile: false, or configure Babel so that it can find the config files.eslint

[vgalatro]

There's a babel config at the root of the project so that's strange it couldn't be found. Could you revert this line and push it back up (in both PRs please)? After that I can approve and merge both.

[accbjt]

@vgalatro Yeah, I was thinking the same thing. Maybe it is a VSCode issue. I updated both PR's. Thanks

[vgalatro]

LGTM!