Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added overflow to section-title links #2027

Merged
merged 8 commits into from
Mar 29, 2024
Merged

Added overflow to section-title links #2027

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e554a61
Added overflow to section-title links
Mar 20, 2024
1bc4a76
Merge branch 'arc-themes-release-version-2.3.0' into THEMES-1466
malavikakoppula Mar 20, 2024
b7e8c29
Merge branch 'arc-themes-release-version-2.3.0' into THEMES-1466
malavikakoppula Mar 22, 2024
664317f
Added flex
Mar 26, 2024
bb46040
Merge branch 'arc-themes-release-version-2.3.0' into THEMES-1466
malavikakoppula Mar 26, 2024
5067814
Merge branch 'arc-themes-release-version-2.3.0' into THEMES-1466
malavikakoppula Mar 26, 2024
c0baf88
Merge branch 'arc-themes-release-version-2.3.0' into THEMES-1466
malavikakoppula Mar 26, 2024
c2a8e5b
Merge branch 'arc-themes-release-version-2.3.0' into THEMES-1466
malavikakoppula Mar 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .storybook/themes/news.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2618,6 +2618,9 @@
),
),
),
"section-title-links": (
"overflow-x": hidden,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is really solving the issue. It's just hiding links that flow off the page:

Screenshot 2024-03-22 at 1 10 23 PM
(The rest of the word Culture, News, Business, and the first part of Footer titles are all off the page).

We'd want the links themselves to break to a new line so they all remain visible.

),
"share-bar": (
"background": var(--background-color),
"box-shadow": var(--global-box-shadow-1),
Expand Down
9 changes: 9 additions & 0 deletions blocks/section-title-block/themes/news.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,5 +23,14 @@
},
"desktop": {}
}
},

"section-title-links": {
"styles": {
"default": {
"overflow-x": "hidden"
},
"desktop": {}
}
}
}
Loading