THEMES-1853: updated husky scripts #2053
Conversation
| . "$(dirname "$0")/_/husky.sh" | ||
|
|
||
| # npx lint-staged | ||
| npm run lint:changed-feature-branch |
There was a problem hiding this comment.
are we still going to use both eslint and prettier? Can we remove prettier from package.json if not using?
There was a problem hiding this comment.
I could add npm run format here too. Forgot that we had that honestly.
There was a problem hiding this comment.
Okay, so that doesn't work as a pre-commit hook. Since things change it kicks you back to the point where everything is just staged and you can't actually commit anything. Since we haven't been using it, I'm just going to remove it for now. We'll have prettier in the git history if we ever want it back.
There was a problem hiding this comment.
Stopped myself, our stylelint config is using prettier as a basis for some of the rules it enforces, so it's being used. The format script is just to run fixes manually.
There was a problem hiding this comment.
Got it. Approving this.
vgalatro
merged commit 9662754
into
arc-themes-release-version-2.3.0
Description
This PR re-enables and updates the husky scripts to be compatible with version 9.x.
Jira Ticket
Acceptance Criteria
Test Steps
git checkout THEMES-1853lint:changed-feature-branchscript should run.lint:changed-feature-branchandtest:changed-feature-branchscripts run.