Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASUB-8303/ Checkout card detail #2054

Conversation

edwardcho1231
Copy link
Contributor

If you have not filled out the checklist below, the pr is not ready for review.

Description

  • Create CheckoutCardDetail component

Jira Ticket

Acceptance Criteria

AC:

  • Create the CheckoutCardDetail with Title, Summary, Link & Children, following the list provided above (a-e)
  • Create an instance of CheckoutCardDetail for 1. Account following the logic defined below.
  • The children will contain the LogIn components that already exist. (check: LogIn, login-links, social-sign-on, …)

Test Steps

  • Add test steps a reviewer must complete to test this PR
  1. Checkout this branch git checkout {branch name}
  2. Run fusion repo with linked blocks npx fusion start -f -l @wpmedia/subscriptions-block
  3. If a user is logged in, it should open the billing address card
  4. If a user is not logged in, it should redirect the user to the log in page and redirect back to checkout once user is logged in.

Effect Of Changes

Before

Example: When I clicked the search button, the button turned red.

[include screenshot or gif or link to video, storybook would be awesome]

After

Example: When I clicked the search button, the button turned green.

[include screenshot or gif or link to video, storybook would be awesome]

Dependencies or Side Effects

Examples of dependencies or side effects are:

Author Checklist

The author of the PR should fill out the following sections to ensure this PR is ready for review.

  • Confirmed all the test steps a reviewer will follow above are working.
  • Confirmed there are no linter errors. Please run npm run lint to check for errors. Often, npm run lint:fix will fix those errors and warnings.
  • Ran this code locally and checked that there are not any unintended side effects. For example, that a CSS selector is scoped only to a particular block.
  • Confirmed this PR has reasonable code coverage. You can run npm run test:coverage to see your progress.
    • Confirmed this PR has unit test files
    • Ran npm run test, made sure all tests are passing
    • If the amount of work to write unit tests for this change are excessive,
      please explain why (so that we can fix it whenever it gets refactored).
  • Confirmed relevant documentation has been updated/added.

Reviewer Checklist

The reviewer of the PR should copy-paste this template into the review comments on review.

  • Linting code actions have passed.
  • Ran the code locally based on the test instructions.
    • I don’t think this is needed to be tested locally. For example, a padding style change (storybook?) or a logic change (write a test).
  • I am a member of the engine theme team so that I can approve and merge this. If you're not on the team, you won't have access to approve and merge this pr.
  • Looked to see that the new or changed code has code coverage, specifically. We want the global code coverage to keep on going up with targeted testing.

@edwardcho1231 edwardcho1231 requested a review from a team as a code owner March 26, 2024 19:50
@edwardcho1231 edwardcho1231 changed the base branch from arc-themes-release-version-2.3.0 to CheckoutBlock_Subscriptions_Feature March 29, 2024 18:39
Copy link
Contributor

@LauraPinilla LauraPinilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @edwardcho1231
Everything looks good to me, just a small comment related to styles. I can see the summary should appear with font-size 14px (e.g. email for 1.Account). However, it has 16px.
Thanks for your work on this!.
Screenshot 2024-04-01 at 8 04 47 a m

@edwardcho1231 edwardcho1231 merged commit 7fed2ac into CheckoutBlock_Subscriptions_Feature Apr 1, 2024
0 of 2 checks passed
@edwardcho1231 edwardcho1231 deleted the ASUB-8303/checkoutCardDetail branch April 1, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants