ASUB-8549 custom buttom for facebook and apple - updating user accoun… #2176

LauraPinilla · 2024-07-02T02:54:58Z

…t management

Be sure to run npm test, npm run lint, and write detailed test steps before requesting reviewers

Description

Updates on Social-sign-on & account management block

https://arcpublishing.atlassian.net/browse/ASUB-8521
https://arcpublishing.atlassian.net/browse/ASUB-8549

There are some AppSec Security alerts, All these will be fixed as part of https://arcpublishing.atlassian.net/browse/ASUB-8539

Test Steps

Use the cdn endpoint https://stagingva-staging-sandbox.api.cdn.arcpublishing.com
Since this tenant has all the Third Auth Providers.

2 Blocks has been updated as part of this PR
Create a page with a Social-Sign-on block. Enable/disable the custom field customButtons. It will render the buttons provided by Fb or Google or the custom buttons included as part of this ticket.
Create a page with account-management block. There you should be able to see the identities attached, or you should be able to attach new identities.

Checkout this branch git checkout ASUB-8521-SocialMediaButtons
Run fusion repo with linked blocks npx fusion start -f -l @wpmedia/identity-block
Create a page with a Social-Sign-on block. Enable/disable the custom field customButtons. It will render the buttons provided by Fb or Google or the custom buttons included as part of this ticket.
4 Create a page with account-management block. There you should be able to see the identities attached, or you should be able to attach/remove identities.

…t management

…MediaButtons

blocks/identity-block/components/social-sign-on/utils/useSocialSignIn.js

edwardcho1231 · 2024-07-09T17:30:58Z

Just curious but what's reasoning behind adding custom button flag on the custom fields instead of just changing the existing button? Thanks.

edwardcho1231 · 2024-07-09T17:39:33Z

blocks/identity-block/components/social-sign-on/_children/GoogleSignIn.jsx

+		if (customButtons) {
+			document.getElementById("custom-google-signin-btn").addEventListener("click", () =>
+				window.google.accounts.id.prompt((notification) => {
+					if (notification.isNotDisplayed() || notification.isSkippedMoment()) {


It seems like google doesn't want you to use isNotDisplayed with FedCM roll out.
https://developers.google.

com/identity/gsi/web/guides/fedcm-migration?s=dc#display_moment

accbjt

@LauraPinilla I left some comments and can we go over how we can test this.

blocks/identity-block/features/account-management/_children/SocialEditableSection.jsx

accbjt · 2024-07-09T17:41:15Z

blocks/identity-block/features/account-management/_children/SocialEditableSection.jsx

-						/>
-					</div>
-				</div>
+				<SocialSignOnEditableFieldContainer


Same here you don't need to use the ternary.

{facebookAppId && ( <div>Your html here</div> )}

blocks/identity-block/features/account-management/_children/SocialEditableSection.jsx

accbjt · 2024-07-09T17:44:20Z

blocks/identity-block/features/account-management/_children/SocialSignOnEditableContainer.jsx

+				document.getElementById("custom-Facebook-signin-btn").addEventListener("click", () => {
+					window.onFacebookSignOn();
+				});
+			setTimeout(() => attachEventListener(), 0);


What is the reason for this timeout if it has 0 milliseconds?

accbjt · 2024-07-10T22:00:14Z

Just curious but what's reasoning behind adding custom button flag on the custom fields instead of just changing the existing button? Thanks.

@edwardcho1231 I think @LauraPinilla wanted to keep the old version just in case the user wanted the old version. I think we can keep it for now just in case a client wants to use the service providers version of it.

edwardcho1231 · 2024-07-12T13:47:14Z

LGTM

blocks/identity-block/intl.json

blocks/identity-block/package.json

blocks/identity-block/themes/news.json

nschubach

useEffect cleanup requests mainly...

blocks/identity-block/components/social-sign-on/_children/FacebookSignIn.jsx

blocks/identity-block/components/social-sign-on/_children/GoogleSignIn.jsx

blocks/identity-block/components/social-sign-on/utils/useSocialSignIn.js

blocks/identity-block/features/account-management/_children/SocialSignOnEditableContainer.jsx

blocks/identity-block/components/social-sign-on/utils/useSocialSignIn.js

…MediaButtons

blocks/identity-block/components/social-sign-on/_children/GoogleSignIn.jsx

blocks/identity-block/components/social-sign-on/utils/useSocialSignIn.js

…MediaButtons

blocks/identity-block/components/social-sign-on/utils/useSocialSignIn.js

nschubach

Definitely feel better about the cleanup, thanks Laura!

including custom buttom for facebook and apple - updating user accoun…

7181967

…t management

LauraPinilla requested a review from a team as a code owner July 2, 2024 02:54

LauraPinilla added 3 commits July 2, 2024 11:14

updating sdk-identity version to 1.88

8c9ba64

Merge branch 'arc-themes-release-version-2.5.0' into ASUB-8521-Social…

03198fb

…MediaButtons

fixing tests

55af4f7

github-advanced-security bot found potential problems Jul 2, 2024

View reviewed changes

fixing tests

061461b

LauraPinilla requested review from accbjt and edwardcho1231 July 3, 2024 13:52

edwardcho1231 reviewed Jul 9, 2024

View reviewed changes

accbjt reviewed Jul 9, 2024

View reviewed changes

update from revisions

661736a

accbjt previously approved these changes Jul 12, 2024

View reviewed changes

accbjt added ready for review The PR author has completed the PR template and is ready for a review additional review The PR author has requested multiple reviewers. Do not merge until at least 2 approvals are complete labels Jul 12, 2024

LauraPinilla removed the additional review The PR author has requested multiple reviewers. Do not merge until at least 2 approvals are complete label Jul 16, 2024

LauraPinilla requested review from vgalatro and malavikakoppula July 17, 2024 14:39

malavikakoppula suggested changes Jul 22, 2024

View reviewed changes

blocks/identity-block/intl.json Outdated Show resolved Hide resolved

blocks/identity-block/package.json Show resolved Hide resolved

malavikakoppula suggested changes Jul 22, 2024

View reviewed changes

blocks/identity-block/themes/news.json Show resolved Hide resolved

malavikakoppula added needs changes The reviewer has requested changes from the PR author and removed ready for review The PR author has completed the PR template and is ready for a review labels Jul 22, 2024

nschubach suggested changes Jul 22, 2024

View reviewed changes

attending feedback

00ee42e

LauraPinilla dismissed accbjt’s stale review via 00ee42e July 25, 2024 00:22

github-advanced-security bot found potential problems Jul 25, 2024

View reviewed changes

fixing issues

7566236

LauraPinilla added 5 commits July 25, 2024 18:31

fixing linting

39fa84a

fixing chromatic

d14102f

fixing Chromatic

113986a

fixing tests

9496cdd

Merge branch 'arc-themes-release-version-2.5.0' into ASUB-8521-Social…

3bf091c

…MediaButtons

LauraPinilla requested review from malavikakoppula and nschubach July 26, 2024 23:08

LauraPinilla added ready for review The PR author has completed the PR template and is ready for a review and removed needs changes The reviewer has requested changes from the PR author labels Jul 26, 2024

nschubach reviewed Jul 29, 2024

View reviewed changes

blocks/identity-block/components/social-sign-on/_children/GoogleSignIn.jsx Outdated Show resolved Hide resolved

nschubach reviewed Jul 29, 2024

View reviewed changes

blocks/identity-block/components/social-sign-on/utils/useSocialSignIn.js Outdated Show resolved Hide resolved

LauraPinilla added 2 commits July 29, 2024 15:57

attending feedback

5db9e95

Merge branch 'arc-themes-release-version-2.5.0' into ASUB-8521-Social…

6ef61d4

…MediaButtons

github-advanced-security bot found potential problems Jul 29, 2024

View reviewed changes

blocks/identity-block/components/social-sign-on/utils/useSocialSignIn.js Dismissed Show dismissed Hide dismissed

blocks/identity-block/components/social-sign-on/utils/useSocialSignIn.js Dismissed Show dismissed Hide dismissed

LauraPinilla requested a review from nschubach July 29, 2024 22:12

nschubach approved these changes Jul 31, 2024

View reviewed changes

malavikakoppula approved these changes Jul 31, 2024

View reviewed changes

LauraPinilla merged commit 957d9ac into arc-themes-release-version-2.5.0 Jul 31, 2024
8 checks passed

LauraPinilla deleted the ASUB-8521-SocialMediaButtons branch July 31, 2024 18:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ASUB-8549 custom buttom for facebook and apple - updating user accoun… #2176

ASUB-8549 custom buttom for facebook and apple - updating user accoun… #2176

LauraPinilla commented Jul 2, 2024 •

edited

Loading

edwardcho1231 commented Jul 9, 2024 •

edited

Loading

edwardcho1231 Jul 9, 2024

accbjt left a comment

accbjt Jul 9, 2024

accbjt Jul 9, 2024

accbjt commented Jul 10, 2024

edwardcho1231 commented Jul 12, 2024

nschubach left a comment

nschubach left a comment

ASUB-8549 custom buttom for facebook and apple - updating user accoun… #2176

ASUB-8549 custom buttom for facebook and apple - updating user accoun… #2176

Conversation

LauraPinilla commented Jul 2, 2024 • edited Loading

Description

Test Steps

edwardcho1231 commented Jul 9, 2024 • edited Loading

edwardcho1231 Jul 9, 2024

Choose a reason for hiding this comment

accbjt left a comment

Choose a reason for hiding this comment

accbjt Jul 9, 2024

Choose a reason for hiding this comment

accbjt Jul 9, 2024

Choose a reason for hiding this comment

accbjt commented Jul 10, 2024

edwardcho1231 commented Jul 12, 2024

nschubach left a comment

Choose a reason for hiding this comment

nschubach left a comment

Choose a reason for hiding this comment

LauraPinilla commented Jul 2, 2024 •

edited

Loading

edwardcho1231 commented Jul 9, 2024 •

edited

Loading