Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Themes 1986: Add Alt tags to images where missing #2186

Merged
merged 8 commits into from
Jul 26, 2024

Conversation

nschubach
Copy link
Contributor

@nschubach nschubach commented Jul 24, 2024

Description

Jira Ticket: THEMES-1986

Adding alt tags to images where they were not previously (as necessary)

Test Steps

  1. Checkout this branch git checkout themes-1986
  2. Run fusion repo with linked blocks npx fusion start -f -l
  3. Verify that the medium and small top table list promos have alt values: http://localhost/pagebuilder/editor/curate?p=puOvG1XS6AaSAy1u&v=vy3r49MKAaSAy1u
  4. Verify that the alt property is applied to the search-results-list, results-list, numbered-list, and simple list where the header is NOT enabled in the block config: http://localhost/pagebuilder/editor/curate?p=pldHYSIJj7fEkicu&v=vOlaaYHh67fEkicu

@nschubach nschubach added the ready for review The PR author has completed the PR template and is ready for a review label Jul 24, 2024
@nschubach nschubach requested a review from a team as a code owner July 24, 2024 18:08
@vgalatro vgalatro self-assigned this Jul 25, 2024
@vgalatro vgalatro added review in progress A review is underway. Even if an approval has been submitted, wait for all reviews to be completed. and removed ready for review The PR author has completed the PR template and is ready for a review labels Jul 25, 2024
Copy link
Contributor

@vgalatro vgalatro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a bunch of docker issues trying to get my local env up and running, but once it was everything here looked good. Approved!

@vgalatro vgalatro added ready to merge It's time! Merge this PR. Woo! and removed review in progress A review is underway. Even if an approval has been submitted, wait for all reviews to be completed. labels Jul 25, 2024
@nschubach nschubach merged commit 14dee61 into arc-themes-release-version-2.5.0 Jul 26, 2024
8 checks passed
@nschubach nschubach deleted the themes-1986 branch July 26, 2024 14:41
@nschubach nschubach restored the themes-1986 branch July 26, 2024 14:41
@nschubach nschubach deleted the themes-1986 branch July 26, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge It's time! Merge this PR. Woo!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants