[Themes 2014] Inline Editing | Large Promo Block #2204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malavikakoppula
added
the
ready for review
nschubach
suggested changes
Aug 29, 2024
| @@ -282,6 +283,7 @@ const LargePromoItem = ({ customFields, arcSite }) => { | |||
| } | |||
|
|
|||
| const { editableContent, searchableField } = useEditableContent(); | |||
| const editable = true; | |||
There was a problem hiding this comment.
This will always be true and is not necessary.
There was a problem hiding this comment.
@nschubach removed editable
malavikakoppula
changed the base branch from
arc-themes-release-version-2.5.1
to
arc-themes-release-version-2.5.2
malavikakoppula
removed
the
ready for review
malavikakoppula
added
the
ready for review
blakeganderson
merged commit 026e20b
into
arc-themes-release-version-2.5.2
8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Jira Ticket: THEMES-2014
Inline edit certain content elements on a promo block within PageBuilder Editor, so that I can curate the homepage promos to drive engagement.
Test Steps
git checkout THEMES-2014npx fusion start -f -l @wpmedia/large-promo-block