Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADX-30 - Safari Gallery Bug #2275

Merged
merged 5 commits into from
Nov 19, 2024
Merged

ADX-30 - Safari Gallery Bug #2275

merged 5 commits into from
Nov 19, 2024

Conversation

blakeganderson
Copy link
Contributor

@blakeganderson blakeganderson commented Nov 18, 2024 •
edited
Loading

Be sure to run npm test, npm run lint, and write detailed test steps before requesting reviewers

Description

Jira Ticket: ADX-30

Changed image height to eliminate scroll bar in gallery in Safari

Test Steps

Add detailed test steps a reviewer must complete to test this PR

  1. Checkout this branch git checkout ADX-30
  2. Run fusion repo with linked blocks npx fusion start -f -l @wpmedia/gallery-block
  3. Examine a page with a gallery block in chrome and Safari and make sure there is no weird overflow scrollbar.

@blakeganderson blakeganderson requested a review from a team as a code owner November 18, 2024 17:42
@blakeganderson blakeganderson mentioned this pull request Nov 19, 2024
Closed
@blakeganderson blakeganderson merged commit 699fac1 into arc-themes-release-version-2.5.2 Nov 19, 2024
8 checks passed
@blakeganderson blakeganderson deleted the ADX-30 branch November 19, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmbrntt rmbrntt rmbrntt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blakeganderson @rmbrntt