Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added text direction variable #226

Merged
merged 2 commits into from
Dec 14, 2023

Conversation

blakeganderson
Copy link
Contributor

@blakeganderson blakeganderson commented Dec 8, 2023

Ticket

Description

Added variable for use in transformations that is equal to 1 if dir="ltr", and -1 if dir="rtl" . This variable can be used in calculations for transformations, such as the side-drawer slide out action

Acceptance Criteria

copy from ticket

Test Steps

  1. Checkout branch - git checkout {branch-name}
  2. Update dependencies - npm i
  3. Run Storybook npm run storybook
  4. Check out the button storybook documentation

Author Checklist

The author of the PR should fill out the following sections to ensure this PR is ready for review.

  • Confirmed all the test steps a reviewer will follow above are working.
  • Ran this code locally and checked that there are not any unintended side effects. For example, that a CSS selector is scoped only to a particular block.
  • Confirmed relevant documentation has been updated/added.
  • Add label - ready for review when the pull request is ready for someone to begin reviewing

Reviewer Checklist

The reviewer of the PR should copy-paste this template into the review comments on review.

  • All GitHub Actions pass
  • Ran the code locally based on the test instructions.
  • Checked Chromatic for Storybook changes, accepted the updates if acceptable
  • Looked to see that the new or changed code has code coverage, specifically. We want the global code coverage to keep on going up with targeted testing.
  • Approve and Add label - ready to merge if you are happy with the pull request
  • Want another reviewer? Add the label additional review

@blakeganderson blakeganderson requested a review from a team as a code owner December 8, 2023 18:23
@blakeganderson blakeganderson added the ready for review The PR author has completed the PR template and is ready for a review label Dec 8, 2023
@blakeganderson blakeganderson merged commit 83a0a46 into arc-themes-release-version-2.1.3 Dec 14, 2023
3 of 5 checks passed
@blakeganderson blakeganderson deleted the THEMES-1363 branch December 14, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review The PR author has completed the PR template and is ready for a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants