-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
THEMES-1221: Update carousel styles #227
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
stylelint
src/components/carousel/_index.scss|109 col 2| Unexpected browser feature "flexbox-gap" is not supported by KaiOS Browser 2.5 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
src/components/carousel/_index.scss|118 col 3| Unexpected browser feature "css-nesting" is not supported by Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 22,23, QQ Browser 13.1, KaiOS Browser 2.5 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
src/components/carousel/_index.scss|121 col 2| Unexpected browser feature "css-nesting" is not supported by Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 22,23, QQ Browser 13.1, KaiOS Browser 2.5 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
src/components/carousel/_index.scss|146 col 2| Unexpected browser feature "css-nesting" is not supported by Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 22,23, QQ Browser 13.1, KaiOS Browser 2.5 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
src/components/carousel/_index.scss|150 col 3| Unexpected browser feature "css-nesting" is not supported by Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 22,23, QQ Browser 13.1, KaiOS Browser 2.5 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
src/components/carousel/_index.scss|194 col 2| Unexpected browser feature "css-nesting" is not supported by Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 22,23, QQ Browser 13.1, KaiOS Browser 2.5 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
src/components/carousel/_index.scss|196 col 3| Unexpected browser feature "css-nesting" is not supported by Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 22,23, QQ Browser 13.1, KaiOS Browser 2.5 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
src/components/carousel/_index.scss|198 col 2| Unexpected browser feature "css-nesting" is not supported by Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 22,23, QQ Browser 13.1, KaiOS Browser 2.5 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
src/components/carousel/_index.scss|200 col 3| Unexpected browser feature "css-nesting" is not supported by Opera Mobile 73, UC Browser for Android 15.5, Samsung Internet 22,23, QQ Browser 13.1, KaiOS Browser 2.5 (plugin/no-unsupported-browser-features) plugin/no-unsupported-browser-features
src/components/carousel/_index.scss|198 col 2| Expected empty line before rule (rule-empty-line-before) rule-empty-line-before
src/components/carousel/_index.scss|193 col 1| Unexpected qualifying type selector "html[dir="rtl"]" (selector-no-qualifying-type) selector-no-qualifying-type
src/components/carousel/_index.scss|194 col 2| Unexpected qualifying type selector "html[dir="rtl"]" (selector-no-qualifying-type) selector-no-qualifying-type
src/components/carousel/_index.scss|198 col 2| Unexpected qualifying type selector "html[dir="rtl"]" (selector-no-qualifying-type) selector-no-qualifying-type
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good, just noticed some duplicate properties between the _index.scss
and the news.json
. The changes are also missing from the commerce.json
.
Could you add a RTL story to index.stories.mdx
as well? So we have it whenever we update Storybook.
src/components/carousel/_index.scss
Outdated
container-name: c-carousel; | ||
container-type: inline-size; | ||
display: grid; | ||
grid-template-areas: "controls" "carousel" "indicators"; | ||
max-inline-size: 100cqi; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these three props (container-name
, container-type
, and max-inline-size
) supposed to be here? They're also on the token, so they end up appearing twice in the final CSS.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, I removed these. I missed moving these over.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good, approved!
Ticket
Description
Update carousel logical properties
Acceptance Criteria
The above logical properties are applied and tested on the gallery component.
Storybook is updated with RTL.
Test Steps
git checkout themes-1221
npm i
Author Checklist
Reviewer Checklist
The reviewer of the PR should copy-paste this template into the review comments on review.