Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Themes 1604 #230

Draft
wants to merge 5 commits into
base: arc-themes-release-version-2.1.4
Choose a base branch
from
Draft

Conversation

nschubach
Copy link
Contributor

Merge #229 first!!

Ticket

Description

Acceptance Criteria

Test Steps

  1. Checkout branch - git checkout themes-1604
  2. Update dependencies - npm i
  3. Run fusion local linking your components
  4. ... see log for test data

Author Checklist

  • Confirmed all the test steps a reviewer will follow above are working.
  • Ran this code locally and checked that there are not any unintended side effects. For example, that a CSS selector is scoped only to a particular block.
  • Confirmed relevant documentation has been updated/added.
  • Add label - ready for review when the pull request is ready for someone to begin reviewing

Reviewer Checklist

The reviewer of the PR should copy-paste this template into the review comments on review.

  • All GitHub Actions pass
  • Ran the code locally based on the test instructions.
  • Checked Chromatic for Storybook changes, accepted the updates if acceptable
  • Looked to see that the new or changed code has code coverage, specifically. We want the global code coverage to keep on going up with targeted testing.
  • Approve and Add label - ready to merge if you are happy with the pull request
  • Want another reviewer? Add the label additional review

@blakeganderson blakeganderson self-assigned this Dec 19, 2023
@blakeganderson blakeganderson added the review in progress A review is underway. Even if an approval has been submitted, wait for all reviews to be completed. label Dec 19, 2023
@nschubach nschubach changed the base branch from arc-themes-release-version-2.1.3 to arc-themes-release-version-2.1.4 January 22, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review in progress A review is underway. Even if an approval has been submitted, wait for all reviews to be completed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants