THEMES-1905: Update signing script to handle failing promised fetches #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nschubach
added
the
ready for review
nschubach
changed the base branch from
arc-themes-release-version-2.3.1
to
arc-themes-release-version-2.4.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update for handling failed hash requests.
Jira Ticket: THEMES-1905
This handles failing signing service fetches by treating it as if there is no hash and not adding it. This is to handle the edge case where an image may exist as a referent in the data where Photo Center may have an incomplete image record.
Test Steps
! since the customer deleted the problem story, I don't have a good way to test this besides running the test suite... !
git checkout themes-1905npm inpm run test -- --watch -osrc/utils/sign-images-in-ans-object/index.js