THEMES-1907: Sign Author Images #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmbrntt
force-pushed
the
sign-author-images
branch
from
6f74b8e to
9c03b9c
Compare
* pull out transform logic * remove redundant * lint fix * Clean up test data * Remove Console log
|
Before merging, please be sure #266 is merged |
* THEMES-1916: Add Additional author object image type * lint fix
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
nschubach
changed the base branch from
arc-themes-release-version-2.3.1
to
arc-themes-release-version-2.4.0
nschubach
reviewed
May 14, 2024
nschubach
reviewed
May 14, 2024
|
feel free to merge this when it's good to go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added an additional check in
signImagesInANSObjectagainstauthorANS to handle the image url as an external image to sign.Jira Ticket: THEMES-1907
Proof
Before
content-apiAfter
content-apistory-feed-queryauthor-apiTest Steps
Add detailed test steps a reviewer must complete to test this PR
git checkout sign-author-images/travel/2022/12/15/get-ahead-on-holiday-travel/http://localhost/pagebuilder/tools/debugger?_website=the-gazette&type=content-debugger&source=content-api&config=%7B%22website_url%22:%22/travel/2022/12/15/get-ahead-on-holiday-travel/%22%7DTo actually test this all the way through, we need to make an update to the author blocks as they aren't expecting to pass in the resize params or ANS image that the Image component expects. That'll be a separate PR
Note
We duplicated resizer code into feed-components which means we should also have this logic included there.