Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-added null value check #267

Merged
merged 1 commit into from
May 24, 2024
Merged

Re-added null value check #267

merged 1 commit into from
May 24, 2024

Conversation

vgalatro
Copy link
Contributor

Description

Added back in a check for null values in the signImagesInANSObject utility. Also added a test for the observed bug.

Test Steps

  1. Checkout this branch - git checkout fix-sign-images-null-handling
  2. Update dependencies - npm i
  3. Run Fusion with components linked npx fusion start
  4. Test a variety of stories using the content-api content source in the PageBuilder debugger.
    • The ID of one story that was experiencing the issue is VNYFD6L5D5EANF7ANLZMG62TQI
  5. Content should fetch and the ANS should appear.

@vgalatro vgalatro requested a review from a team as a code owner May 24, 2024 16:38
@vgalatro vgalatro added the ready for review The PR author has completed the PR template and is ready for a review label May 24, 2024
@blakeganderson blakeganderson self-assigned this May 24, 2024
@blakeganderson blakeganderson added the review in progress A review is underway. Even if an approval has been submitted, wait for all reviews to be completed. label May 24, 2024
blakeganderson
blakeganderson approved these changes May 24, 2024
View reviewed changes
Copy link
Contributor

@blakeganderson blakeganderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vgalatro vgalatro merged commit 04c6784 into arc-themes-release-version-2.4.0 May 24, 2024
7 checks passed
@vgalatro vgalatro deleted the fix-sign-images-null-handling branch May 24, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakeganderson blakeganderson blakeganderson approved these changes

Assignees

@blakeganderson blakeganderson

Labels
ready for review The PR author has completed the PR template and is ready for a review review in progress A review is underway. Even if an approval has been submitted, wait for all reviews to be completed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vgalatro @blakeganderson