Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

THEMES-1906: Helper for manually entered image URLs #268

Merged
merged 3 commits into from
Jun 6, 2024

Conversation

vgalatro
Copy link
Contributor

@vgalatro vgalatro commented Jun 5, 2024

Description

Jira Ticket: THEMES-1906

Adds helper for extracting the photo center image ID from cloudfront URLs. Includes a parameter to skip the regex match if the calling block already determined the image has everything needed for the resizer.

Test Steps

  1. Checkout this branch - git checkout THEMES-1906
  2. Update dependencies - npm i
  3. See blocks PR (THEMES-1906: Use correct info when calling signing service arc-themes-blocks#2162) for further instructions.

@vgalatro vgalatro requested a review from a team as a code owner June 5, 2024 13:47
@vgalatro vgalatro added the ready for review The PR author has completed the PR template and is ready for a review label Jun 5, 2024
@vgalatro vgalatro merged commit 20360b2 into arc-themes-release-version-2.5.0 Jun 6, 2024
7 checks passed
@vgalatro vgalatro deleted the THEMES-1906 branch June 6, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review The PR author has completed the PR template and is ready for a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants