Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

porting video ssr fix to a branch based on 2.3.0 #271

Closed

Conversation

vgalatro
Copy link
Contributor

@vgalatro vgalatro commented Jul 3, 2024

Be sure to run npm test, npm run lint, and write detailed test steps before requesting reviewers

Description

Jira Ticket: THEMES-

Information about what you changed for this PR. Include any dependencies, companion PRs, relevant screenshots, or config changes.

Test Steps

Add detailed test steps a reviewer must complete to test this PR

  1. Checkout this branch - git checkout {branch name}
  2. Update dependencies - npm i
  3. Run Storybook npm run storybook
  4. {Next ....}

@vgalatro vgalatro added the do not merge Do not merge, wait to merge this ticket until this label is removed. label Jul 3, 2024
@vgalatro vgalatro requested a review from a team as a code owner July 3, 2024 16:11
@vgalatro vgalatro added ready for review The PR author has completed the PR template and is ready for a review and removed do not merge Do not merge, wait to merge this ticket until this label is removed. labels Jul 3, 2024
@vgalatro vgalatro changed the base branch from arc-themes-release-version-2.3.0 to arc-themes-release-version-2.3.99 July 3, 2024 19:10
@vgalatro vgalatro closed this Jul 3, 2024
@vgalatro vgalatro deleted the video-ssr-fix-2.3.0 branch July 3, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review The PR author has completed the PR template and is ready for a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant