THEMES-1864: Button styling fix #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malavikakoppula
suggested changes
Aug 15, 2024
There was a problem hiding this comment.
@vgalatro Secondary reverse button label is not visible until hover it. In Figma, it has neutral-3 background.
|
@malavikakoppula , I believe that is just the box's background color and not part of the button. It's meant to be used on dark backgrounds and the colors for the rest state are listed here: |
So, including border, button label should also appear on hover? |
|
@malavikakoppula , right, it's just the background for storybook is also white, which makes it hard to see. |
malavikakoppula
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Jira Ticket: THEMES-1864
This PR fixes the styling for the button component. It was out of sync with what is in the Figma style docs. The button styles are located here: https://www.figma.com/design/NBjMF1v4mzwv9jkn7NEq9V/Themes-Block-Styling-2.0?node-id=10862-135976&t=YU12KWjCz73C7KdP-0.
Test Steps
git checkout THEMES-1864npm inpm run storybookPrimary,Primary-reverse,Secondary, andSecondary-reversematch the Figma docs. Check both the at rest and hover states.