Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated TwitterIcon path #762

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

malavikakoppula
Copy link
Contributor

@malavikakoppula malavikakoppula commented Oct 24, 2023

Description

Update with new Twittericon

Jira Ticket

Acceptance Criteria

copy from ticket

Test Steps

  1. Checkout branch - git checkout THEMES-1440
  2. Update dependencies - npm i
  3. Run footer-block frok pagebuilder
  4. Check out the Twitter icon in footer-block
Screenshot 2023-10-24 at 3 08 08 PM

Review Checklist

The author of the PR should fill out the following sections to ensure this PR is ready for review.

  • Confirmed all the test steps above are working
  • Confirmed there are no linter errors
  • Confirmed this PR has reasonable code coverage
    • Confirmed this PR has unit test files
    • Ran npm test, made sure all tests are passing
    • If the amount of work to write unit tests for this change are excessive,
      please explain why (so that we can fix it whenever it gets refactored).
  • Confirmed relevant documentation has been updated/added.

@vgalatro
Copy link
Contributor

Shouldn't this be pointing at arc-themes-release-version-1.31? Or is it supposed to be a hotfix for the current version?

@malavikakoppula malavikakoppula changed the base branch from arc-themes-release-version-1.30 to arc-themes-release-version-1.31 November 1, 2023 15:24
@malavikakoppula malavikakoppula merged commit 65b90fa into arc-themes-release-version-1.31 Nov 6, 2023
1 of 3 checks passed
@malavikakoppula malavikakoppula deleted the THEMES-1440 branch November 6, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants