THEMES-1479: #767

vgalatro · 2023-10-30T19:47:08Z

Description

PR to fix incomplete escaping of the image source URL in the MetaData helper.

Code scanning alert is remedied.

Checkout branch git checkout THEMES-1479
Run fusion with ENGINE_SDK_REPO= set in your .env
Visit any article page with a promo item set.
The og:image and twitter:image meta fields should still have working images set in the content attribute.

Confirmed all the test steps above are working
Confirmed there are no linter errors
Confirmed this PR has reasonable code coverage
- Confirmed this PR has unit test files
- Ran npm test, made sure all tests are passing
- If the amount of work to write unit tests for this change are excessive,
  please explain why (so that we can fix it whenever it gets refactored).
Confirmed relevant documentation has been updated/added.

THEMES-1479: updated URL parsing to use built in object.

d4bef93

vgalatro requested a review from a team as a code owner October 30, 2023 19:47

vgalatro added the ready for review label Oct 30, 2023

nschubach approved these changes Oct 30, 2023

View reviewed changes

nschubach added ready to merge and removed ready for review labels Oct 30, 2023

vgalatro merged commit 6d98582 into arc-themes-release-version-1.31 Oct 31, 2023

vgalatro deleted the THEMES-1479 branch October 31, 2023 13:24