Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated twittericon #771

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Updated twittericon #771

merged 1 commit into from
Nov 9, 2023

Conversation

malavikakoppula
Copy link
Contributor

@malavikakoppula malavikakoppula commented Nov 7, 2023 •
edited by jira bot
Loading

Description

Update with new Twittericon

Jira Ticket

Acceptance Criteria

https://www.figma.com/file/NBjMF1v4mzwv9jkn7NEq9V/Themes-Block-Styling-2.0?type=design&node-id=10811%3A147806&mode=design&t=jG5oCFMUMr3b84Ro-1

Test Steps

  1. Checkout branch - git checkout THEMES-1440
  2. Update dependencies - npm i
  3. Run footer-block from pagebuilder
  4. Check out the Twitter icon in footer-block

Review Checklist

The author of the PR should fill out the following sections to ensure this PR is ready for review.

  • Confirmed all the test steps above are working
  • Confirmed there are no linter errors
  • Confirmed this PR has reasonable code coverage
    • Confirmed this PR has unit test files
    • Ran npm test, made sure all tests are passing
    • If the amount of work to write unit tests for this change are excessive,
      please explain why (so that we can fix it whenever it gets refactored).
  • Confirmed relevant documentation has been updated/added.

@malavikakoppula malavikakoppula changed the base branch from arc-themes-release-version-1.29 to arc-themes-release-version-1.29.1 November 9, 2023 15:56
@malavikakoppula malavikakoppula marked this pull request as ready for review November 9, 2023 15:57
@malavikakoppula malavikakoppula requested a review from a team as a code owner November 9, 2023 15:57
@malavikakoppula malavikakoppula merged commit 1390608 into arc-themes-release-version-1.29.1 Nov 9, 2023
5 checks passed
@malavikakoppula malavikakoppula deleted the THEMES-1440-hotfix branch November 9, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nschubach nschubach nschubach approved these changes

Assignees
No one assigned
Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@malavikakoppula @nschubach