Merge pull request #74 from WPMedia/TMEDIA-270-remove-css-correspondi…

…ng-docs-override Tmedia 270 remove css corresponding docs override
WPMedia · Jul 19, 2021 · 69deb2e · 69deb2e
2 parents 5b6f9b6 + ed59f19
commit 69deb2e
Show file tree

Hide file tree

Showing 9 changed files with 18 additions and 3 deletions.
diff --git a/readme.md b/readme.md
@@ -30,6 +30,8 @@ Include as an dependency in a custom block:
 
 - Fusion will then inject these overrides and framework. Set the following in the feature pack's blocks.json:
 
+NOTE: sassVariableOverrides is deprecated in favor of using site-specific js values using styled-components
+
 `feature-pack/blocks.json`
 ```json
 {

diff --git a/scss/_colors.scss b/scss/_colors.scss
@@ -7,6 +7,8 @@
 
 // Base Colors for the theme.
 //
+// NOTE: This is being deprecated. We are in the process of improving enhanced styles and using styled-components to achieve this composition.
+//
 // $primary-color - #1B6FA6; Primary color
 // $secondary-color - #1B6FA6; Placeholder for the future
 // $success-color - #00A321; Success color

diff --git a/scss/homepage.md b/scss/homepage.md
@@ -37,6 +37,8 @@ purpose:
 
 Here is an example of what a the CSS setup in the `block.json` might look like.
 
+NOTE: sassVariableOverrides is deprecated in favor of using site-specific js values using styled-components
+
 ```
 {
   "cssFramework": "@wpmedia/news-theme-css",

diff --git a/scss/typography/_index.scss b/scss/typography/_index.scss
@@ -1,6 +1,6 @@
 // Typography
 // 
-// The primary and secondary font families can be overridden per website using the [Theme Settings](https://redirector.arcpublishing.com/alc/arc-products/themes/user-docs/theme-settings/) `primary-font-family` and `secondary-font-family`, respectively.
+// This is now deprecated. Instead, we recommend using site-specific values and a default font value. We use styled-components to ensure this is dynamic. The primary and secondary font families can be overridden per website using the [Theme Settings](https://redirector.arcpublishing.com/alc/arc-products/themes/user-docs/theme-settings/) `primary-font-family` and `secondary-font-family`, respectively.
 //
 // Styleguide 5.0.0
 

diff --git a/styleguide/index.html b/styleguide/index.html
@@ -296,6 +296,7 @@ <h3>Getting Started:</h3>
 </table>
 <h4>Example</h4>
 <p>Here is an example of what a the CSS setup in the <code>block.json</code> might look like.</p>
+<p>NOTE: sassVariableOverrides is deprecated in favor of using site-specific js values using styled-components</p>
 <pre class="hljs"><code class="language-">{
   &quot;cssFramework&quot;: &quot;@wpmedia/news-theme-css&quot;,
   &quot;cssImport&quot;: &quot;~@wpmedia/news-theme-css/scss/index&quot;,

diff --git a/styleguide/item-3-1.html b/styleguide/item-3-1.html
@@ -256,6 +256,10 @@ <h2 class="kss-section__item kss-section__item--depth-2">
               </h2>
             </a>
 
+            <div
+              class="kss-section__description">
+              <p>NOTE: This is being deprecated. We are in the process of improving enhanced styles and using styled-components to achieve this composition.</p>
+</div>
 
             <ul class="kss-parameters">
               <li class="kss-parameters__item">

diff --git a/styleguide/item-5.html b/styleguide/item-5.html
@@ -272,7 +272,7 @@ <h1 class="kss-section__item kss-section__item--depth-1">
 
             <div
               class="kss-section__description">
-              <p>The primary and secondary font families can be overridden per website using the <a href="https://redirector.arcpublishing.com/alc/arc-products/themes/user-docs/theme-settings/">Theme Settings</a> <code>primary-font-family</code> and <code>secondary-font-family</code>, respectively.</p>
+              <p>This is now deprecated. Instead, we recommend using site-specific values and a default font value. We use styled-components to ensure this is dynamic. The primary and secondary font families can be overridden per website using the <a href="https://redirector.arcpublishing.com/alc/arc-products/themes/user-docs/theme-settings/">Theme Settings</a> <code>primary-font-family</code> and <code>secondary-font-family</code>, respectively.</p>
 </div>
 
           </article>

diff --git a/styleguide/section-3.html b/styleguide/section-3.html
@@ -286,6 +286,10 @@ <h2 class="kss-section__item kss-section__item--depth-2">
               </h2>
             </a>
 
+            <div
+              class="kss-section__description">
+              <p>NOTE: This is being deprecated. We are in the process of improving enhanced styles and using styled-components to achieve this composition.</p>
+</div>
 
             <ul class="kss-parameters">
               <li class="kss-parameters__item">

diff --git a/styleguide/section-5.html b/styleguide/section-5.html
@@ -272,7 +272,7 @@ <h1 class="kss-section__item kss-section__item--depth-1">
 
             <div
               class="kss-section__description">
-              <p>The primary and secondary font families can be overridden per website using the <a href="https://redirector.arcpublishing.com/alc/arc-products/themes/user-docs/theme-settings/">Theme Settings</a> <code>primary-font-family</code> and <code>secondary-font-family</code>, respectively.</p>
+              <p>This is now deprecated. Instead, we recommend using site-specific values and a default font value. We use styled-components to ensure this is dynamic. The primary and secondary font families can be overridden per website using the <a href="https://redirector.arcpublishing.com/alc/arc-products/themes/user-docs/theme-settings/">Theme Settings</a> <code>primary-font-family</code> and <code>secondary-font-family</code>, respectively.</p>
 </div>
 
           </article>
-Original file line number
+Diff line change
@@ Expand Up / @@ -30,6 +30,8 @@ Include as an dependency in a custom block: @@
     - Fusion will then inject these overrides and framework. Set the following in the feature pack's blocks.json:
+    NOTE: sassVariableOverrides is deprecated in favor of using site-specific js values using styled-components
     `feature-pack/blocks.json`
     ```json
     {
@@ Expand Down @@