Skip to content

Navbar + JS smooth transition #71

Open

Description

@kylerlittle

The navbar should be fixed at some point. It has three primary issues I can find.

  • It's unreadable on much of the site due to the web font. Either make a solid background for the navbar, or use javascript to vary the font color to a complementary readable color as we scroll
  • At screen widths of less than ~700px, the MLH trust badge covers things on the navbar
  • The "smooth" transitions don't work correctly if you're not at the top of the page. The javascript calculates the offset from the top of the page, and transitions based on that. This is wrong. It should get where you are currently on the page, the location of the desired target, and transition in this way.

Activity

  1. kylerlittle commented on Jan 11, 2019

    @kylerlittle
    ContributorAuthor

    Fixed the MLH trust badge with some media queries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions