fix: always use dj.wxyc.org for email links#145
Merged
JacksonMeade merged 3 commits intomainfrom Feb 7, 2026
Merged
Conversation
Member
|
I'm wondering if you would mind implementing tests to cover this? |
Contributor
Author
I've added a unit test for the behavior of the rewrite function, which is the most 'breakable' part of what I've done here. I will not be writing end to end testing for this until we have new users; this is a zero-level kind of feature that should have been in the original implementation. |
jakebromberg
approved these changes
Feb 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is absolutely critical for getting login flow working
Rewrites email verification and password reset URLs to use the frontend domain instead of the backend API domain, while preserving path and query parameters.
What Changed
rewriteUrlForFrontendhelper that replaces only the host and protocol, leaving path and query params intactbuildResetUrl)Why
Email links now point to
dj.wxyc.orginstead ofapi.wxyc.org, so users land on the frontend. ThecallbackURLquery parameter remains a relative path (e.g.,/onboarding) that the frontend resolves correctly. This removes the need for frontend URL sanitization helpers.