test(schema): re-home the five FKs #2239 de-declared under the NO ACTION block

tests/unit/database/schema.fk-cascades.test.ts

@@ -34,6 +34,13 @@ function expectOnDelete(tableVar: string, columnDbName: string, expectedAction:
   expect(block).toContain(`'${expectedAction}'`);
 }
 
+function expectNoOnDelete(tableVar: string, columnDbName: string) {
+  const block = getColumnBlock(tableVar, columnDbName);
+  expect(block).not.toBeNull();
+  expect(block).toContain('.references(');
+  expect(block).not.toContain('onDelete');
+}
+
 describe('FK cascade/set-null rules in schema.ts', () => {
   describe('should use onDelete: "set null"', () => {
     it('schedule.assigned_dj_id → user.id', () => {
@@ -44,10 +51,6 @@ describe('FK cascade/set-null rules in schema.ts', () => {
       expectOnDelete('schedule', 'assigned_dj_id2', 'set null');
     });
 
-    it('schedule.specialty_id → specialty_shows.id', () => {
-      expectOnDelete('schedule', 'specialty_id', 'set null');
-    });
-
     it('shows.primary_dj_id → user.id', () => {
       expectOnDelete('shows', 'primary_dj_id', 'set null');
     });
@@ -78,28 +81,51 @@ describe('FK cascade/set-null rules in schema.ts', () => {
       expectOnDelete('reviews', 'album_id', 'cascade');
     });
 
-    it('genre_artist_crossreference.artist_id → artists.id', () => {
-      expectOnDelete('genre_artist_crossreference', 'artist_id', 'cascade');
+    it('artist_library_crossreference.library_id → library.id', () => {
+      expectOnDelete('artist_library_crossreference', 'library_id', 'cascade');
+    });
+  });
+
+  describe('should NOT have onDelete (intentional NO ACTION)', () => {
+    // The five below were DE-DECLARED by WXYC/Backend-Service#2239. schema.ts
+    // used to claim CASCADE (or SET NULL, for schedule.specialty_id) on each,
+    // but every one of them is plain NO ACTION in production and in a CI
+    // database built from the migration chain from empty -- no migration ever
+    // created them any other way. #2239 corrected schema.ts to describe what
+    // the database actually enforces rather than patching the database to
+    // match a declaration nothing relied on: no code path in apps/ or shared/
+    // deletes a shows, artists, genres, or specialty_shows row, so adding the
+    // cascades would have armed five destructive deletes across decades of
+    // flowsheet and library history for zero callers.
+    //
+    // These assertions are the reason the decision cannot silently rot back.
+    // If a future change genuinely needs one of these to cascade, add the
+    // cascade in the PR that introduces the delete path, update the matching
+    // case here, and pair it with a migration -- the deployed constraint has
+    // to move too. Do not simply re-add `onDelete` to schema.ts; that is the
+    // exact drift #2239 existed to remove, and the integration guard at
+    // tests/integration/fk-on-delete-general-guard.spec.js will fail on it.
+
+    it('schedule.specialty_id → specialty_shows.id (#2239)', () => {
+      expectNoOnDelete('schedule', 'specialty_id');
     });
 
-    it('genre_artist_crossreference.genre_id → genres.id', () => {
-      expectOnDelete('genre_artist_crossreference', 'genre_id', 'cascade');
+    it('genre_artist_crossreference.artist_id → artists.id (#2239)', () => {
+      expectNoOnDelete('genre_artist_crossreference', 'artist_id');
     });
 
-    it('artist_library_crossreference.artist_id → artists.id', () => {
-      expectOnDelete('artist_library_crossreference', 'artist_id', 'cascade');
+    it('genre_artist_crossreference.genre_id → genres.id (#2239)', () => {
+      expectNoOnDelete('genre_artist_crossreference', 'genre_id');
     });
 
-    it('artist_library_crossreference.library_id → library.id', () => {
-      expectOnDelete('artist_library_crossreference', 'library_id', 'cascade');
+    it('artist_library_crossreference.artist_id → artists.id (#2239)', () => {
+      expectNoOnDelete('artist_library_crossreference', 'artist_id');
     });
 
-    it('show_djs.show_id → shows.id', () => {
-      expectOnDelete('show_djs', 'show_id', 'cascade');
+    it('show_djs.show_id → shows.id (#2239)', () => {
+      expectNoOnDelete('show_djs', 'show_id');
     });
-  });
 
-  describe('should NOT have onDelete (intentional NO ACTION)', () => {
     it('library.artist_id → artists.id', () => {
       const block = getColumnBlock('library', 'artist_id');
       expect(block).not.toBeNull();