Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add external links to Chapter Profile page #11

Closed
4 tasks
brylie opened this issue Jun 21, 2021 · 8 comments · Fixed by #42
Closed
4 tasks

Add external links to Chapter Profile page #11

brylie opened this issue Jun 21, 2021 · 8 comments · Fixed by #42
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest-accepted help wanted Extra attention is needed

Comments

@brylie
Copy link
Collaborator

brylie commented Jun 21, 2021

Chapter profile pages display the Chapter title and description. We would like to add a bit more information to Chapter profiles, such as:

links to

  • social media
  • chapter website

Task

  • discuss what fields to add to the Chapter model (i.e. field names and types)
  • add desired field(s) to Chapter model
  • make migrations
  • render field data in the Chapter profile template

Possible resource(s)

This might be a good task for the Wagtail StreamField, in that it would allow zero or more (up to perhaps three) links to be added to the Chapter. StreamFields support limiting the number of sub-blocks.

@brylie brylie added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Jun 21, 2021
@Upasanadhameliya
Copy link
Contributor

@brylie I would like to work on this issue. Lets start with the discussion of what fields are needed to be added in the Chapter model. Also can you give a bit of an overview as to what the chapters app is supposed to do or what is it related to?

@brylie
Copy link
Collaborator Author

brylie commented Oct 20, 2021

The idea for "chapters" is basically groups of people that share a geographic location. E.g. people from the same country or city.

https://github.com/brylie/wagtail-social-network/blob/e2d3d01bfaae6bbac56421058235fbc7eba1c984/project/chapters/models.py#L36-L51

As food for thought, we could start more generic and just model groups and then later create a chapter sub-type that inherits from group. I am thinking about how the Codebuddies.org project is organized into Groups and Hangouts. Groups on Codebuddies.org are topic-focused, like Python Programming (group).

@Upasanadhameliya
Copy link
Contributor

@brylie So here's what I understood, basically the base model group will have attributes like name, members, and some methods as well like join, delete, etc. Now when chapters would inherit from the group, it would be adding extra features, like region or continent to the group. But the base group could be inherited in the future by different models like countries or sports etc. Is my thinking right about it?

@brylie
Copy link
Collaborator Author

brylie commented Oct 21, 2021

Yep. That way people can form groups around various interests, topics, etc.

We would use a many-to-many relationship for group membership.

@Upasanadhameliya
Copy link
Contributor

@brylie Assign me to this issue, I would like to work on it

@Upasanadhameliya
Copy link
Contributor

@brylie Now that one pr has been merged, would you like to add some more features to chapters? Are there any tasks remaining? If so, feel free to discuss further about it.

@brylie
Copy link
Collaborator Author

brylie commented Nov 11, 2021

We can still add a "website" field to the Group model, as per the issue description.

Similarly, issue #12 might be interesting.

@Upasanadhameliya
Copy link
Contributor

I will open a draft pr shortly in order to add the social media links

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest-accepted help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants