Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add website and social media links to chapter profile #42

Merged
merged 4 commits into from
Nov 22, 2021

Conversation

Upasanadhameliya
Copy link
Contributor

@Upasanadhameliya Upasanadhameliya commented Nov 15, 2021

Closes #11

@Upasanadhameliya
Copy link
Contributor Author

@brylie The RichTextField() already has a provision to insert links (See image below). And each chapter has introduction which is a type of a RichTextField. So do we need another RichTextField for these links or are we just repeating ourselves? See this.

ques73

@brylie
Copy link
Collaborator

brylie commented Nov 15, 2021

One issue to note is that the RichTextField can contain any rich text content, by design.

However, if we want to encourage a particular field, like "chapter homepage" or "social media link", we need to add them as a top-level URL field. When we have specific, top-level fields, we can control where and how they render on the page whereas a rich text field is a bit of a blob.

StreamField block containing the option to add either
social media links or website links was added. Through this
feature, the chapters can contain links to webpages corresponding
to the theme.
The links were made to render in the individual chapters
templates if present, by the use of bootstrap "navs".
@Upasanadhameliya
Copy link
Contributor Author

Upasanadhameliya commented Nov 16, 2021

@brylie I added the links fields in the backend, as well as made them available on the templates. Should I make this pr ready for review or are there any other changes/additions?

@brylie
Copy link
Collaborator

brylie commented Nov 17, 2021

Yeah, this is a nice PR. It will serve as both proof-of-concept and the basis for subsequent improvements like social media icons or something similar 😃

@Upasanadhameliya Upasanadhameliya marked this pull request as ready for review November 18, 2021 04:24
@Upasanadhameliya
Copy link
Contributor Author

@brylie the pr is ready for review!

@brylie brylie merged commit a9bb049 into Wagify:develop Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add external links to Chapter Profile page
2 participants