Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change publish to use http relay client in handlers #142

Merged
merged 1 commit into from
Oct 24, 2023
Merged

fix: change publish to use http relay client in handlers #142

merged 1 commit into from
Oct 24, 2023

Conversation

geekbrother
Copy link
Contributor

@geekbrother geekbrother commented Oct 23, 2023 •
edited
Loading

Description

This PR changes the use of publish from websocket client to the HTTP relay client to solve the websocket disconnect issue.

Resolves #74

How Has This Been Tested?

Integration test.

Due Diligence

  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

@geekbrother geekbrother self-assigned this Oct 23, 2023
@geekbrother geekbrother force-pushed the max/fix/change_publish_to_http branch from f5c13f6 to 64620e5 Compare October 23, 2023 21:16
@geekbrother geekbrother mentioned this pull request Oct 23, 2023
Closed
3 tasks
@geekbrother geekbrother marked this pull request as ready for review October 23, 2023 21:34
chris13524
chris13524 requested changes Oct 23, 2023
View reviewed changes
Copy link
Member

@chris13524 chris13524 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we need this for the /notify endpoint too?

@geekbrother
Copy link
Contributor Author

Don't we need this for the /notify endpoint too?

I think not because we are already using the HTTP relay client when processing publishing jobs.

chris13524
chris13524 requested changes Oct 24, 2023
View reviewed changes
.github/workflows/sub-validate.yml Outdated Show resolved Hide resolved
@chris13524
Copy link
Member

Don't we need this for the /notify endpoint too?

I think not because we are already using the HTTP relay client when processing publishing jobs.

Ah you're right

@geekbrother geekbrother force-pushed the max/fix/change_publish_to_http branch from 64620e5 to 815bbc8 Compare October 24, 2023 13:08
@geekbrother geekbrother force-pushed the max/fix/change_publish_to_http branch from 815bbc8 to ac1fb8b Compare October 24, 2023 18:38
@geekbrother geekbrother merged commit f6bc5ac into main Oct 24, 2023
10 checks passed
@geekbrother geekbrother deleted the max/fix/change_publish_to_http branch October 24, 2023 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris13524 chris13524 chris13524 approved these changes

Assignees

@geekbrother geekbrother

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: handler functions do not anticipate websocket disconnection
2 participants
@geekbrother @chris13524