Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ECS rollout #159

Merged
merged 3 commits into from
Oct 30, 2023
Merged

fix: ECS rollout #159

merged 3 commits into from
Oct 30, 2023

Conversation

chris13524
Copy link
Member

@chris13524 chris13524 commented Oct 27, 2023

Description

Revert at-most-once replica guarantees as it results in 10 minutes of visible downtime which affects healthchecks. Context: https://walletconnect.slack.com/archives/C04JHSB53MK/p1698418167594559?thread_ts=1697599030.449369&cid=C04JHSB53MK

Removes database_subnets as they result in some instances failing to start because they cannot access RDS. Seems a replica can only be present on a single subnet. Context: https://walletconnect.slack.com/archives/C04JHSB53MK/p1698291144785299

Resolves #158

How Has This Been Tested?

Not tested

Due Diligence

  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

@chris13524 chris13524 self-assigned this Oct 27, 2023
@chris13524 chris13524 temporarily deployed to prod October 27, 2023 15:34 — with GitHub Actions Inactive
@chris13524 chris13524 temporarily deployed to staging October 27, 2023 15:34 — with GitHub Actions Inactive
Copy link
Member

@arein arein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Painful. Nice find!

@chris13524 chris13524 merged commit f77049e into main Oct 30, 2023
11 checks passed
@chris13524 chris13524 deleted the fix/ecs-rollout branch October 30, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: ECS rollout
3 participants